Apply suggestions from code review

Co-authored-by: Simon Christ <SimonChrist@gmx.de>
This commit is contained in:
Nicholas Bauer 2021-08-30 12:20:05 -04:00 committed by GitHub
parent d195534ed4
commit abccc9f5ba
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1215,22 +1215,14 @@ function mesh3d_triangles(x, y, z, cns)
return X, Y, Z return X, Y, Z
end end
const _attrsymbolcache = Dict{Symbol, Dict{Symbol, Symbol}}() const _attrsymbolcache = Dict{Symbol, Dict{Symbol, Symbol}}(
:x => Dict( k => Symbol("x", String(k)) for k in keys(_axis_defaults)),
:y => Dict( k => Symbol("y", String(k)) for k in keys(_axis_defaults)),
:z => Dict( k => Symbol("z", String(k)) for k in keys(_axis_defaults))
)
get_attr_symbol(letter::Symbol, keyword::String) = get_attr_symbol(letter, Symbol(keyword)) get_attr_symbol(letter::Symbol, keyword::String) = get_attr_symbol(letter, Symbol(keyword))
function get_attr_symbol(letter::Symbol, keyword::Symbol) function get_attr_symbol(letter::Symbol, keyword::Symbol)
lt = if haskey(_attrsymbolcache, letter) return _attrsymbolcache[letter][keyword]
_attrsymbolcache[letter]
else
_attrsymbolcache[letter] = Dict{Symbol, Symbol}()
end
lk = if haskey(lt, keyword)
lt[keyword]
else
lt[keyword] = Symbol(letter, keyword)
end
return lk
end end