From abccc9f5bacbe7664e87f14101fecc47e39ba9b1 Mon Sep 17 00:00:00 2001 From: Nicholas Bauer Date: Mon, 30 Aug 2021 12:20:05 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Simon Christ --- src/utils.jl | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/src/utils.jl b/src/utils.jl index 159805fc..6f6dd351 100644 --- a/src/utils.jl +++ b/src/utils.jl @@ -1215,22 +1215,14 @@ function mesh3d_triangles(x, y, z, cns) return X, Y, Z end -const _attrsymbolcache = Dict{Symbol, Dict{Symbol, Symbol}}() +const _attrsymbolcache = Dict{Symbol, Dict{Symbol, Symbol}}( + :x => Dict( k => Symbol("x", String(k)) for k in keys(_axis_defaults)), + :y => Dict( k => Symbol("y", String(k)) for k in keys(_axis_defaults)), + :z => Dict( k => Symbol("z", String(k)) for k in keys(_axis_defaults)) +) get_attr_symbol(letter::Symbol, keyword::String) = get_attr_symbol(letter, Symbol(keyword)) function get_attr_symbol(letter::Symbol, keyword::Symbol) - lt = if haskey(_attrsymbolcache, letter) - _attrsymbolcache[letter] - else - _attrsymbolcache[letter] = Dict{Symbol, Symbol}() - end - - lk = if haskey(lt, keyword) - lt[keyword] - else - lt[keyword] = Symbol(letter, keyword) - end - - return lk + return _attrsymbolcache[letter][keyword] end