From fb27704d2bd5739416f33e83f8f4d0189ee02fb7 Mon Sep 17 00:00:00 2001 From: Daniel Schwabeneder Date: Mon, 25 Jan 2021 16:10:09 +0100 Subject: [PATCH 1/3] fix tests --- src/backends/hdf5.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backends/hdf5.jl b/src/backends/hdf5.jl index 699b1529..050992aa 100644 --- a/src/backends/hdf5.jl +++ b/src/backends/hdf5.jl @@ -440,8 +440,8 @@ end #Read KW from group: function _read(::Type{KW}, grp::Group) d = KW() - gnames = names(grp) - for k in gnames + gkeys = keys(grp) + for k in gkeys try v = _read_typed(grp, k) d[Symbol(k)] = v From 9d3514224e0d6cd4f74aabe2dad6763bca1c7e42 Mon Sep 17 00:00:00 2001 From: Daniel Schwabeneder Date: Mon, 25 Jan 2021 16:16:28 +0100 Subject: [PATCH 2/3] use GKSwstype environment variable to avoid GKS warnings in tests --- .github/workflows/benchmark.yml | 3 ++- .github/workflows/ci.yml | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 7047da27..57b36ed9 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -8,6 +8,7 @@ jobs: if: "!contains(github.event.head_commit.message, '[skip ci]')" env: GKS_ENCODING: "utf8" + GKSwstype: 100 runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -28,4 +29,4 @@ jobs: - name: Post results run: julia -e 'using BenchmarkCI; BenchmarkCI.postjudge()' env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ea965cb7..ad8a5b7d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,6 +13,7 @@ jobs: if: "!contains(github.event.head_commit.message, '[skip ci]')" env: GKS_ENCODING: "utf8" + GKSwstype: 100 name: Julia ${{ matrix.version }} - ${{ matrix.os }} runs-on: ${{ matrix.os }} From da1b9adc17d875580e8fd9ea3587c31ae7d09a93 Mon Sep 17 00:00:00 2001 From: Daniel Schwabeneder Date: Mon, 25 Jan 2021 16:28:17 +0100 Subject: [PATCH 3/3] env as string --- .github/workflows/benchmark.yml | 2 +- .github/workflows/ci.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 57b36ed9..944788d5 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -8,7 +8,7 @@ jobs: if: "!contains(github.event.head_commit.message, '[skip ci]')" env: GKS_ENCODING: "utf8" - GKSwstype: 100 + GKSwstype: "100" runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ad8a5b7d..797cc072 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ jobs: if: "!contains(github.event.head_commit.message, '[skip ci]')" env: GKS_ENCODING: "utf8" - GKSwstype: 100 + GKSwstype: "100" name: Julia ${{ matrix.version }} - ${{ matrix.os }} runs-on: ${{ matrix.os }}