fix scale warnings for layouts (#3992)

* fix scale warnings for layouts

* don't run ci twice on PR

* use broadcasting for scalar case
This commit is contained in:
Simon Christ 2021-12-09 10:32:06 +01:00 committed by GitHub
parent 461476f4ed
commit cab76f67e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 1 deletions

View File

@ -2,6 +2,8 @@ name: ci
on:
push:
branches:
- master
pull_request:
defaults:

View File

@ -1644,7 +1644,7 @@ function warn_on_unsupported_scales(pkg::AbstractBackend, plotattributes::AKW)
for k in (:xscale, :yscale, :zscale, :scale)
if haskey(plotattributes, k)
v = plotattributes[k]
if !is_scale_supported(pkg, v)
if !all(is_scale_supported.(Ref(pkg), v))
@warn(
"scale $v is unsupported with $pkg. Choose from: $(supported_scales(pkg))"
)

View File

@ -40,6 +40,7 @@ end
include("test_defaults.jl")
include("test_pipeline.jl")
include("test_axes.jl")
include("test_layouts.jl")
include("test_contours.jl")
include("test_axis_letter.jl")
include("test_components.jl")

9
test/test_layouts.jl Normal file
View File

@ -0,0 +1,9 @@
using Plots, Test
@testset "Subplot sclicing" begin
pl = @test_nowarn plot(rand(4,8), layout=4, yscale=[:identity :identity :log10 :log10])
@test pl[1][:yaxis][:scale] == :identity
@test pl[2][:yaxis][:scale] == :identity
@test pl[3][:yaxis][:scale] == :log10
@test pl[4][:yaxis][:scale] == :log10
end