Apply suggestions from code review

Co-authored-by: t-bltg <tf.bltg@gmail.com>
This commit is contained in:
Simon Christ 2021-08-26 16:23:25 +02:00 committed by GitHub
parent 616ba9954f
commit c98df7a98d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -229,7 +229,7 @@ function gaston_add_series(plt::Plot{GastonBackend}, series::Series)
if gsp.dims == 2 && z === nothing if gsp.dims == 2 && z === nothing
for (n, seg) in enumerate(series_segments(series, st; check = true)) for (n, seg) in enumerate(series_segments(series, st; check = true))
i, rng = seg.attr_index, seg.range i, rng = seg.attr_index, seg.range
fr =_cycle(series[:fillrange], 1:length(x[rng])) #### fr =_cycle(series[:fillrange], 1:length(x[rng]))
for sc in gaston_seriesconf!(sp, series, i, n == 1) for sc in gaston_seriesconf!(sp, series, i, n == 1)
push!(curves, Gaston.Curve(x[rng], y[rng], nothing, fr, sc)) push!(curves, Gaston.Curve(x[rng], y[rng], nothing, fr, sc))
end end
@ -310,7 +310,7 @@ function gaston_seriesconf!(
if fr !== nothing # filled curves, but not filled curves with markers if fr !== nothing # filled curves, but not filled curves with markers
push!(curveconf, "w filledcurves fc $fc fs solid border lc $lc lw $lw dt $dt,'' w lines lc $lc lw $lw dt $dt") push!(curveconf, "w filledcurves fc $fc fs solid border lc $lc lw $lw dt $dt,'' w lines lc $lc lw $lw dt $dt")
elseif series[:markershape] == :none # simplepath elseif series[:markershape] == :none # simplepath
push!(curveconf, "w lines lc $lc dt $dt lw $lw") push!(curveconf, "w lines lc $lc dt $dt lw $lw")
else else
pt, ps, mc = gaston_mk_ms_mc(series, clims, i) pt, ps, mc = gaston_mk_ms_mc(series, clims, i)
push!(curveconf, "w lp lc $mc dt $dt lw $lw pt $pt ps $ps") push!(curveconf, "w lp lc $mc dt $dt lw $lw pt $pt ps $ps")