From c52d5e44c7cf5e87a5b0a88643ef09cae4de6d7c Mon Sep 17 00:00:00 2001
From: Daniel Schwabeneder <daschw@disroot.org>
Date: Sat, 27 Jun 2020 13:08:22 +0200
Subject: [PATCH] allow failures on julia 1.3 windows

---
 .github/workflows/ci.yml | 27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index bc8a1f14..05f734c2 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -33,14 +33,11 @@ jobs:
           # - x86
         allow-failure: [false]
         include:
+          ## allow failures on nightly
           - version: 'nightly'
             os: ubuntu-latest
             arch: x64
             allow-failure: true
-          # - version: 'nightly'
-          #   os: ubuntu-latest
-          #   arch: x86
-          #   allow-failure: true
           - version: 'nightly'
             os: macOS-latest
             arch: x64
@@ -49,10 +46,20 @@ jobs:
             os: windows-latest
             arch: x64
             allow-failure: true
-          # - version: 'nightly'
-          #   os: windows-latest
-          #   arch: x86
-          #   allow-failure: true
+          ## allow failures for julia 1.3 windows (test_images work but differ)
+          - version: '1.3'
+            os: windows-latest
+            arch: x64
+            allow-failure: true
+        ## if we want to run tests on x86:
+        #   - version: 'nightly'
+        #     os: ubuntu-latest
+        #     arch: x86
+        #     allow-failure: true
+        #   - version: 'nightly'
+        #     os: windows-latest
+        #     arch: x86
+        #     allow-failure: true
         # exclude:
         #   - os: macOS-latest
         #     arch: x86
@@ -75,15 +82,13 @@ jobs:
             ${{ runner.os }}-test-
             ${{ runner.os }}-
 
+      ## maybe required if we ever want to run graphical tests for plotly
       # OS Dependencies
       # - name: Ubuntu OS dependencies
       #   if: startsWith(matrix.os,'ubuntu')
       #   run: |
       #    ./test/install_wkhtmltoimage.sh
 
-      #  at-spi2-core, libgtk-3-dev,  libgtk-3-0, and xvfb  are already installed: https://github.com/actions/virtual-environments/blob/master/images/linux/scripts/installers/basic.sh
-
-
       # TESTCMD
       - name: Default TESTCMD
         run: echo ::set-env name=TESTCMD::"julia"