diff --git a/.travis.yml b/.travis.yml index bbeac50e..63017e49 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,7 +4,7 @@ os: - linux # - osx julia: - - 0.6 + - 0.7 matrix: allow_failures: - julia: nightly @@ -44,7 +44,7 @@ notifications: # uncomment the following lines to override the default test script script: - if [[ -a .git/shallow ]]; then git fetch --unshallow; fi - - julia -e 'Pkg.clone(pwd()); Pkg.build("Plots")' + - julia -e 'using Pkg; Pkg.add(pwd()); Pkg.build("Plots")' - julia test/travis_commands.jl # - julia -e 'Pkg.clone("ImageMagick"); Pkg.build("ImageMagick")' # - julia -e 'Pkg.clone("GR"); Pkg.build("GR")' diff --git a/REQUIRE b/REQUIRE index c256c0a6..b9cf9457 100644 --- a/REQUIRE +++ b/REQUIRE @@ -1,4 +1,4 @@ -julia 0.6 +julia 0.7-alpha RecipesBase 0.2.3 PlotUtils 0.4.1 diff --git a/deps/build.jl b/deps/build.jl index 2fef2af8..ad328049 100644 --- a/deps/build.jl +++ b/deps/build.jl @@ -3,6 +3,6 @@ local_fn = joinpath(dirname(@__FILE__), "plotly-latest.min.js") if !isfile(local_fn) - info("Cannot find deps/plotly-latest.min.js... downloading latest version.") + @info("Cannot find deps/plotly-latest.min.js... downloading latest version.") download("https://cdn.plot.ly/plotly-latest.min.js", local_fn) end diff --git a/src/Plots.jl b/src/Plots.jl index ea7ff92d..d67a0381 100644 --- a/src/Plots.jl +++ b/src/Plots.jl @@ -6,6 +6,7 @@ using Reexport import StaticArrays using StaticArrays.FixedSizeArrays +using Dates, Printf, Statistics, Base64, LinearAlgebra @reexport using RecipesBase import RecipesBase: plot, plot!, animate @@ -264,29 +265,29 @@ xgrid!(args...; kw...) = plot!(; xgrid = args ygrid!(args...; kw...) = plot!(; ygrid = args, kw...) let PlotOrSubplot = Union{Plot, Subplot} - title!(plt::PlotOrSubplot, s::AbstractString; kw...) = plot!(plt; title = s, kw...) - xlabel!(plt::PlotOrSubplot, s::AbstractString; kw...) = plot!(plt; xlabel = s, kw...) - ylabel!(plt::PlotOrSubplot, s::AbstractString; kw...) = plot!(plt; ylabel = s, kw...) - xlims!(plt::PlotOrSubplot, lims::Tuple{T,S}; kw...) where {T<:Real,S<:Real} = plot!(plt; xlims = lims, kw...) - ylims!(plt::PlotOrSubplot, lims::Tuple{T,S}; kw...) where {T<:Real,S<:Real} = plot!(plt; ylims = lims, kw...) - zlims!(plt::PlotOrSubplot, lims::Tuple{T,S}; kw...) where {T<:Real,S<:Real} = plot!(plt; zlims = lims, kw...) - xlims!(plt::PlotOrSubplot, xmin::Real, xmax::Real; kw...) = plot!(plt; xlims = (xmin,xmax), kw...) - ylims!(plt::PlotOrSubplot, ymin::Real, ymax::Real; kw...) = plot!(plt; ylims = (ymin,ymax), kw...) - zlims!(plt::PlotOrSubplot, zmin::Real, zmax::Real; kw...) = plot!(plt; zlims = (zmin,zmax), kw...) - xticks!(plt::PlotOrSubplot, ticks::AVec{T}; kw...) where {T<:Real} = plot!(plt; xticks = ticks, kw...) - yticks!(plt::PlotOrSubplot, ticks::AVec{T}; kw...) where {T<:Real} = plot!(plt; yticks = ticks, kw...) - xticks!(plt::PlotOrSubplot, + global title!(plt::PlotOrSubplot, s::AbstractString; kw...) = plot!(plt; title = s, kw...) + global xlabel!(plt::PlotOrSubplot, s::AbstractString; kw...) = plot!(plt; xlabel = s, kw...) + global ylabel!(plt::PlotOrSubplot, s::AbstractString; kw...) = plot!(plt; ylabel = s, kw...) + global xlims!(plt::PlotOrSubplot, lims::Tuple{T,S}; kw...) where {T<:Real,S<:Real} = plot!(plt; xlims = lims, kw...) + global ylims!(plt::PlotOrSubplot, lims::Tuple{T,S}; kw...) where {T<:Real,S<:Real} = plot!(plt; ylims = lims, kw...) + global zlims!(plt::PlotOrSubplot, lims::Tuple{T,S}; kw...) where {T<:Real,S<:Real} = plot!(plt; zlims = lims, kw...) + global xlims!(plt::PlotOrSubplot, xmin::Real, xmax::Real; kw...) = plot!(plt; xlims = (xmin,xmax), kw...) + global ylims!(plt::PlotOrSubplot, ymin::Real, ymax::Real; kw...) = plot!(plt; ylims = (ymin,ymax), kw...) + global zlims!(plt::PlotOrSubplot, zmin::Real, zmax::Real; kw...) = plot!(plt; zlims = (zmin,zmax), kw...) + global xticks!(plt::PlotOrSubplot, ticks::AVec{T}; kw...) where {T<:Real} = plot!(plt; xticks = ticks, kw...) + global yticks!(plt::PlotOrSubplot, ticks::AVec{T}; kw...) where {T<:Real} = plot!(plt; yticks = ticks, kw...) + global xticks!(plt::PlotOrSubplot, ticks::AVec{T}, labels::AVec{S}; kw...) where {T<:Real,S<:AbstractString} = plot!(plt; xticks = (ticks,labels), kw...) - yticks!(plt::PlotOrSubplot, + global yticks!(plt::PlotOrSubplot, ticks::AVec{T}, labels::AVec{S}; kw...) where {T<:Real,S<:AbstractString} = plot!(plt; yticks = (ticks,labels), kw...) - xgrid!(plt::PlotOrSubplot, args...; kw...) = plot!(plt; xgrid = args, kw...) - ygrid!(plt::PlotOrSubplot, args...; kw...) = plot!(plt; ygrid = args, kw...) - annotate!(plt::PlotOrSubplot, anns...; kw...) = plot!(plt; annotation = anns, kw...) - annotate!(plt::PlotOrSubplot, anns::AVec{T}; kw...) where {T<:Tuple} = plot!(plt; annotation = anns, kw...) - xflip!(plt::PlotOrSubplot, flip::Bool = true; kw...) = plot!(plt; xflip = flip, kw...) - yflip!(plt::PlotOrSubplot, flip::Bool = true; kw...) = plot!(plt; yflip = flip, kw...) - xaxis!(plt::PlotOrSubplot, args...; kw...) = plot!(plt; xaxis = args, kw...) - yaxis!(plt::PlotOrSubplot, args...; kw...) = plot!(plt; yaxis = args, kw...) + global xgrid!(plt::PlotOrSubplot, args...; kw...) = plot!(plt; xgrid = args, kw...) + global ygrid!(plt::PlotOrSubplot, args...; kw...) = plot!(plt; ygrid = args, kw...) + global annotate!(plt::PlotOrSubplot, anns...; kw...) = plot!(plt; annotation = anns, kw...) + global annotate!(plt::PlotOrSubplot, anns::AVec{T}; kw...) where {T<:Tuple} = plot!(plt; annotation = anns, kw...) + global xflip!(plt::PlotOrSubplot, flip::Bool = true; kw...) = plot!(plt; xflip = flip, kw...) + global yflip!(plt::PlotOrSubplot, flip::Bool = true; kw...) = plot!(plt; yflip = flip, kw...) + global xaxis!(plt::PlotOrSubplot, args...; kw...) = plot!(plt; xaxis = args, kw...) + global yaxis!(plt::PlotOrSubplot, args...; kw...) = plot!(plt; yaxis = args, kw...) end diff --git a/src/args.jl b/src/args.jl index 671485d0..e9bfa36c 100644 --- a/src/args.jl +++ b/src/args.jl @@ -15,7 +15,7 @@ function add_non_underscore_aliases!(aliases::Dict{Symbol,Symbol}) for (k,v) in aliases s = string(k) if '_' in s - aliases[Symbol(replace(s, "_", ""))] = v + aliases[Symbol(replace(s, "_" => ""))] = v end end end @@ -176,7 +176,7 @@ const _positionAliases = Dict{Symbol,Symbol}( const _allScales = [:identity, :ln, :log2, :log10, :asinh, :sqrt] const _logScales = [:ln, :log2, :log10] -const _logScaleBases = Dict(:ln => e, :log2 => 2.0, :log10 => 10.0) +const _logScaleBases = Dict(:ln => ℯ, :log2 => 2.0, :log10 => 10.0) const _scaleAliases = Dict{Symbol,Symbol}( :none => :identity, :log => :log10, @@ -188,11 +188,11 @@ const _allGridSyms = [:x, :y, :z, :all, :both, :on, :yes, :show, :none, :off, :no, :hide] const _allGridArgs = [_allGridSyms; string.(_allGridSyms); nothing] -hasgrid(arg::Void, letter) = false +hasgrid(arg::Nothing, letter) = false hasgrid(arg::Bool, letter) = arg function hasgrid(arg::Symbol, letter) if arg in _allGridSyms - arg in (:all, :both, :on) || contains(string(arg), string(letter)) + arg in (:all, :both, :on) || occursin(string(letter), string(arg)) else warn("Unknown grid argument $arg; $(Symbol(letter, :grid)) was set to `true` instead.") true @@ -206,11 +206,11 @@ const _allShowaxisSyms = [:x, :y, :z, :all, :both, :on, :yes, :show, :off, :no, :hide] const _allShowaxisArgs = [_allGridSyms; string.(_allGridSyms)] -showaxis(arg::Void, letter) = false +showaxis(arg::Nothing, letter) = false showaxis(arg::Bool, letter) = arg function showaxis(arg::Symbol, letter) if arg in _allGridSyms - arg in (:all, :both, :on, :yes) || contains(string(arg), string(letter)) + arg in (:all, :both, :on, :yes) || occursin(string(letter), string(arg)) else warn("Unknown showaxis argument $arg; $(Symbol(letter, :showaxis)) was set to `true` instead.") true @@ -654,6 +654,7 @@ function handleColors!(d::KW, arg, csym::Symbol) d[csym] = c end return true + catch end false end @@ -1028,7 +1029,7 @@ function extractGroupArgs(vs::Tuple, args...) end # allow passing NamedTuples for a named legend entry -@require NamedTuples begin +@require NamedTuples = "73a701b4-84e1-5df0-88ff-1968ee2ee8dc" begin legendEntryFromTuple(ns::NamedTuples.NamedTuple) = join(["$k = $v" for (k, v) in zip(keys(ns), values(ns))], ", ") @@ -1131,7 +1132,7 @@ function convertLegendValue(val::Symbol) end end convertLegendValue(val::Bool) = val ? :best : :none -convertLegendValue(val::Void) = :none +convertLegendValue(val::Nothing) = :none convertLegendValue(v::Tuple{S,T}) where {S<:Real, T<:Real} = v convertLegendValue(v::AbstractArray) = map(convertLegendValue, v) diff --git a/src/axes.jl b/src/axes.jl index 1410b28b..fa7499f7 100644 --- a/src/axes.jl +++ b/src/axes.jl @@ -251,7 +251,7 @@ function get_ticks(axis::Axis) # discrete ticks... n = length(dvals) rng = if ticks == :auto - Int[round(Int,i) for i in linspace(1, n, 15)] + Int[round(Int,i) for i in range(1, stop=n, length=15)] else # if ticks == :all 1:n end @@ -265,7 +265,7 @@ function get_ticks(axis::Axis) end elseif typeof(ticks) <: Union{AVec, Int} if !isempty(dvals) && typeof(ticks) <: Int - rng = Int[round(Int,i) for i in linspace(1, length(dvals), ticks)] + rng = Int[round(Int,i) for i in range(1, stop=length(dvals), length=ticks)] axis[:continuous_values][rng], dvals[rng] else # override ticks, but get the labels @@ -310,7 +310,7 @@ function expand_extrema!(axis::Axis, v::Number) end # these shouldn't impact the extrema -expand_extrema!(axis::Axis, ::Void) = axis[:extrema] +expand_extrema!(axis::Axis, ::Nothing) = axis[:extrema] expand_extrema!(axis::Axis, ::Bool) = axis[:extrema] diff --git a/src/backends.jl b/src/backends.jl index 94199b00..3e1affce 100644 --- a/src/backends.jl +++ b/src/backends.jl @@ -1,3 +1,4 @@ +using Pkg struct NoBackend <: AbstractBackend end @@ -134,8 +135,7 @@ CurrentBackend(sym::Symbol) = CurrentBackend(sym, _backend_instance(sym)) function pickDefaultBackend() env_default = get(ENV, "PLOTS_DEFAULT_BACKEND", "") if env_default != "" - try - Pkg.installed(env_default) # this will error if not installed + if env_default in keys(Pkg.installed()) sym = Symbol(lowercase(env_default)) if haskey(_backendType, sym) return backend(sym) @@ -143,7 +143,7 @@ function pickDefaultBackend() warn("You have set PLOTS_DEFAULT_BACKEND=$env_default but it is not a valid backend package. Choose from:\n\t", join(sort(_backends), "\n\t")) end - catch + else warn("You have set PLOTS_DEFAULT_BACKEND=$env_default but it is not installed.") end end @@ -152,7 +152,7 @@ function pickDefaultBackend() # which one someone will want to use if they have the package installed...accounting for # features, speed, and robustness for pkgstr in ("GR", "PyPlot", "PlotlyJS", "PGFPlots", "UnicodePlots", "InspectDR", "GLVisualize") - if Pkg.installed(pkgstr) != nothing + if pkgstr in keys(Pkg.installed()) return backend(Symbol(lowercase(pkgstr))) end end diff --git a/src/backends/glvisualize.jl b/src/backends/glvisualize.jl index b8a4ed04..2ec0b928 100644 --- a/src/backends/glvisualize.jl +++ b/src/backends/glvisualize.jl @@ -9,7 +9,7 @@ TODO * fix units in all visuals (e.g dotted lines, marker scale, surfaces) =# -@require Revise begin +@require Revise = "295af30f-e4ad-537b-8983-00126c2a3abe" begin Revise.track(Plots, joinpath(Pkg.dir("Plots"), "src", "backends", "glvisualize.jl")) end @@ -80,7 +80,7 @@ function _initialize_backend(::GLVisualizeBackend; kw...) is_marker_supported(::GLVisualizeBackend, shape::GLVisualize.AllPrimitives) = true is_marker_supported(::GLVisualizeBackend, shape::Union{Vector{Matrix{C}}, Matrix{C}}) where {C<:Colorant} = true is_marker_supported(::GLVisualizeBackend, shape::Shape) = true - const GL = Plots + GL = Plots end end @@ -397,7 +397,7 @@ function gappy(x, ps) return last(ps) - x end function ticks(points, resolution) - Float16[gappy(x, points) for x = linspace(first(points),last(points), resolution)] + Float16[gappy(x, points) for x = range(first(points), stop=last(points), length=resolution)] end @@ -901,12 +901,12 @@ function gl_boxplot(d, kw_args) # filter y values = y[filter(i -> _cycle(x,i) == glabel, 1:length(y))] # compute quantiles - q1,q2,q3,q4,q5 = quantile(values, linspace(0,1,5)) + q1,q2,q3,q4,q5 = quantile(values, range(0, stop=1, length=5)) # notch n = Plots.notch_width(q2, q4, length(values)) # warn on inverted notches? if notch && !warning && ( (q2>(q3-n)) || (q4<(q3+n)) ) - warn("Boxplot's notch went outside hinges. Set notch to false.") + @warn("Boxplot's notch went outside hinges. Set notch to false.") warning = true # Show the warning only one time end @@ -1005,7 +1005,7 @@ end function scale_for_annotations!(series::Series, scaletype::Symbol = :pixels) anns = series[:series_annotations] - if anns != nothing && !isnull(anns.baseshape) + if anns != nothing && anns.baseshape != nothing # we use baseshape to overwrite the markershape attribute # with a list of custom shapes for each msw, msh = anns.scalefactor @@ -1331,7 +1331,7 @@ end function gl_surface(x,y,z, kw_args) - if isa(x, Range) && isa(y, Range) + if isa(x, AbstractRange) && isa(y, AbstractRange) main = z kw_args[:ranges] = (x, y) else @@ -1347,7 +1347,7 @@ function gl_surface(x,y,z, kw_args) if get(kw_args, :wireframe, false) points = map(Point3f0, zip(vec(x), vec(y), vec(z))) faces = Cuint[] - idx = (i,j) -> sub2ind(size(z), i, j) - 1 + idx = (i,j) -> CartesianIndices(size(z), i, j) - 1 for i=1:size(z,1), j=1:size(z,2) i < size(z,1) && push!(faces, idx(i, j), idx(i+1, j)) diff --git a/src/backends/gr.jl b/src/backends/gr.jl index 483e717f..e94b69c1 100644 --- a/src/backends/gr.jl +++ b/src/backends/gr.jl @@ -3,7 +3,7 @@ # significant contributions by @jheinen -@require Revise begin +@require Revise = "295af30f-e4ad-537b-8983-00126c2a3abe" begin Revise.track(Plots, joinpath(Pkg.dir("Plots"), "src", "backends", "gr.jl")) end @@ -144,7 +144,7 @@ gr_set_fillcolor(c) = GR.setfillcolorind(gr_getcolorind(_cycle(c,1))) gr_set_markercolor(c) = GR.setmarkercolorind(gr_getcolorind(_cycle(c,1))) gr_set_textcolor(c) = GR.settextcolorind(gr_getcolorind(_cycle(c,1))) gr_set_transparency(α::Real) = GR.settransparency(clamp(α, 0, 1)) -function gr_set_transparency(::Void) end +function gr_set_transparency(::Nothing) end # -------------------------------------------------------------------------------------- @@ -196,7 +196,7 @@ gr_inqtext(x, y, s::Symbol) = gr_inqtext(x, y, string(s)) function gr_inqtext(x, y, s) if length(s) >= 2 && s[1] == '$' && s[end] == '$' GR.inqtextext(x, y, s[2:end-1]) - elseif search(s, '\\') != 0 || contains(s, "10^{") + elseif something(findfirst(isequal('\\'), s), 0) != 0 || occursin("10^{", s) GR.inqtextext(x, y, s) else GR.inqtext(x, y, s) @@ -208,7 +208,7 @@ gr_text(x, y, s::Symbol) = gr_text(x, y, string(s)) function gr_text(x, y, s) if length(s) >= 2 && s[1] == '$' && s[end] == '$' GR.mathtex(x, y, s[2:end-1]) - elseif search(s, '\\') != 0 || contains(s, "10^{") + elseif something(findfirst(isequal('\\'), s), 0) != 0 || occursin("10^{", s) GR.textext(x, y, s) else GR.text(x, y, s) @@ -317,7 +317,7 @@ function normalize_zvals(zv::AVec, clims::NTuple{2, <:Real}) if vmin == vmax zeros(length(zv)) else - clamp.((zv - vmin) ./ (vmax - vmin), 0, 1) + clamp.((zv .- vmin) ./ (vmax .- vmin), 0, 1) end end @@ -485,7 +485,7 @@ function gr_colorbar(sp::Subplot, clims) xmin, xmax = gr_xy_axislims(sp)[1:2] gr_set_viewport_cmap(sp) l = zeros(Int32, 1, 256) - l[1,:] = Int[round(Int, _i) for _i in linspace(1000, 1255, 256)] + l[1,:] = Int[round(Int, _i) for _i in range(1000, stop=1255, length=256)] GR.setscale(0) GR.setwindow(xmin, xmax, clims[1], clims[2]) GR.cellarray(xmin, xmax, clims[2], clims[1], 1, length(l), l) @@ -502,16 +502,16 @@ function gr_legend_pos(s::Symbol,w,h) if str == "best" str = "topright" end - if contains(str,"right") + if occursin("right", str) xpos = viewport_plotarea[2] - 0.05 - w - elseif contains(str,"left") + elseif occursin("left", str) xpos = viewport_plotarea[1] + 0.11 else xpos = (viewport_plotarea[2]-viewport_plotarea[1])/2 - w/2 +.04 end - if contains(str,"top") + if occursin("top", str) ypos = viewport_plotarea[4] - 0.06 - elseif contains(str,"bottom") + elseif occursin("bottom", str) ypos = viewport_plotarea[3] + h + 0.06 else ypos = (viewport_plotarea[4]-viewport_plotarea[3])/2 + h/2 @@ -531,7 +531,7 @@ const _gr_gradient_alpha = ones(256) function gr_set_gradient(c) grad = isa(c, ColorGradient) ? c : cgrad() - for (i,z) in enumerate(linspace(0, 1, 256)) + for (i,z) in enumerate(range(0, stop=1, length=256)) c = grad[z] GR.setcolorrep(999+i, red(c), green(c), blue(c)) _gr_gradient_alpha[i] = alpha(c) @@ -718,7 +718,7 @@ function gr_display(sp::Subplot{GRBackend}, w, h, viewport_canvas) for ax in (sp[:xaxis], sp[:yaxis]) v = series[ax[:letter]] if diff(collect(extrema(diff(v))))[1] > 1e-6*std(v) - warn("GR: heatmap only supported with equally spaced data.") + @warn("GR: heatmap only supported with equally spaced data.") end end x, y = heatmap_edges(series[:x], sp[:xaxis][:scale]), heatmap_edges(series[:y], sp[:yaxis][:scale]) @@ -1051,7 +1051,7 @@ function gr_display(sp::Subplot{GRBackend}, w, h, viewport_canvas) if typeof(series[:levels]) <: AbstractArray h = series[:levels] else - h = series[:levels] > 1 ? linspace(zmin, zmax, series[:levels]) : [(zmin + zmax) / 2] + h = series[:levels] > 1 ? range(zmin, stop=zmax, length=series[:levels]) : [(zmin + zmax) / 2] end if series[:fillrange] != nothing GR.surface(x, y, z, GR.OPTION_CELL_ARRAY) @@ -1069,7 +1069,7 @@ function gr_display(sp::Subplot{GRBackend}, w, h, viewport_canvas) if cmap gr_set_line(1, :solid, yaxis[:foreground_color_axis]) gr_set_viewport_cmap(sp) - l = (length(h) > 1) ? round.(Int32, 1000 + (h - ignorenan_minimum(h)) / (ignorenan_maximum(h) - ignorenan_minimum(h)) * 255) : Int32[1000, 1255] + l = (length(h) > 1) ? round.(Int32, 1000 .+ (h .- ignorenan_minimum(h)) ./ (ignorenan_maximum(h) - ignorenan_minimum(h)) .* 255) : Int32[1000, 1255] GR.setwindow(xmin, xmax, zmin, zmax) GR.cellarray(xmin, xmax, zmax, zmin, 1, length(l), l) ztick = 0.5 * GR.tick(zmin, zmax) @@ -1358,10 +1358,10 @@ const _gr_mimeformats = Dict( "image/svg+xml" => "svg", ) -const _gr_wstype_default = @static if is_linux() +const _gr_wstype_default = @static if Sys.islinux() "x11" # "cairox11" -elseif is_apple() +elseif Sys.isapple() "quartz" else "use_default" @@ -1379,7 +1379,7 @@ for (mime, fmt) in _gr_mimeformats ENV["GKS_FILEPATH"] = filepath gr_display(plt, $fmt) GR.emergencyclosegks() - write(io, readstring(filepath)) + write(io, read(filepath, String)) rm(filepath) if env != "0" ENV["GKSwstype"] = env diff --git a/src/backends/hdf5.jl b/src/backends/hdf5.jl index a82a277f..0d8c1901 100644 --- a/src/backends/hdf5.jl +++ b/src/backends/hdf5.jl @@ -28,7 +28,7 @@ Read from .hdf5 file using: - Should be reliable for archival purposes. ==# -@require Revise begin +@require Revise = "295af30f-e4ad-537b-8983-00126c2a3abe" begin Revise.track(Plots, joinpath(Pkg.dir("Plots"), "src", "backends", "hdf5.jl")) end @@ -39,7 +39,7 @@ struct HDF5PlotNative; end #Indentifies a data element that can natively be hand struct HDF5CTuple; end #Identifies a "complex" tuple structure mutable struct HDF5Plot_PlotRef - ref::Union{Plot, Void} + ref::Union{Plot, Nothing} end @@ -146,9 +146,9 @@ function _initialize_backend(::HDF5Backend) export HDF5 if length(HDF5PLOT_MAP_TELEM2STR) < 1 #Possible element types of high-level data types: - const telem2str = Dict{String, Type}( + telem2str = Dict{String, Type}( "NATIVE" => HDF5PlotNative, - "VOID" => Void, + "VOID" => Nothing, "BOOL" => Bool, "SYMBOL" => Symbol, "TUPLE" => Tuple, @@ -315,9 +315,9 @@ function _hdf5plot_gwrite(grp, k::String, v::Array{Any}) warn("Cannot write Array: $k=$v") end =# -function _hdf5plot_gwrite(grp, k::String, v::Void) +function _hdf5plot_gwrite(grp, k::String, v::Nothing) grp[k] = 0 - _hdf5plot_writetype(grp, k, Void) + _hdf5plot_writetype(grp, k, Nothing) end function _hdf5plot_gwrite(grp, k::String, v::Bool) grp[k] = Int(v) @@ -344,7 +344,7 @@ end function _hdf5plot_gwrite(grp, k::String, d::Dict) # warn("Cannot write dict: $k=$d") end -function _hdf5plot_gwrite(grp, k::String, v::Range) +function _hdf5plot_gwrite(grp, k::String, v::AbstractRange) _hdf5plot_gwrite(grp, k, collect(v)) #For now end function _hdf5plot_gwrite(grp, k::String, v::ARGB{N0f8}) @@ -365,7 +365,7 @@ function _hdf5plot_gwritearray(grp, k::String, v::Array{T}) where T sz = size(v) for iter in eachindex(v) - coord = ind2sub(sz, iter) + coord = LinearIndices(sz, iter) elem = v[iter] idxstr = join(coord, "_") _hdf5plot_gwrite(vgrp, "v$idxstr", v[iter]) @@ -409,15 +409,15 @@ function _hdf5plot_gwrite(grp, k::String, v::Surface) _hdf5plot_gwrite(grp, "data2d", v.surf) _hdf5plot_writetype(grp, Surface) end -#TODO: "Properly" support Nullable using _hdf5plot_writetype? -function _hdf5plot_gwrite(grp, k::String, v::Nullable) - if isnull(v) - _hdf5plot_gwrite(grp, k, nothing) - else - _hdf5plot_gwrite(grp, k, v.value) - end - return -end +# #TODO: "Properly" support Nullable using _hdf5plot_writetype? +# function _hdf5plot_gwrite(grp, k::String, v::Nullable) +# if isnull(v) +# _hdf5plot_gwrite(grp, k, nothing) +# else +# _hdf5plot_gwrite(grp, k, v.value) +# end +# return +# end function _hdf5plot_gwrite(grp, k::String, v::SeriesAnnotations) #Currently no support for SeriesAnnotations @@ -485,7 +485,7 @@ function _hdf5plot_readcount(grp) #Read directly from group end _hdf5plot_convert(T::Type{HDF5PlotNative}, v) = v -_hdf5plot_convert(T::Type{Void}, v) = nothing +_hdf5plot_convert(T::Type{Nothing}, v) = nothing _hdf5plot_convert(T::Type{Bool}, v) = (v!=0) _hdf5plot_convert(T::Type{Symbol}, v) = Symbol(v) _hdf5plot_convert(T::Type{Tuple}, v) = tuple(v...) #With Vector{T<:Number} @@ -530,7 +530,7 @@ function _hdf5plot_read(grp, k::String, T::Type{Array}, dtid) #ANY result = Array{Any}(sz) for iter in eachindex(result) - coord = ind2sub(sz, iter) + coord = LinearIndices(sz, iter) idxstr = join(coord, "_") result[iter] = _hdf5plot_read(grp, "v$idxstr") end diff --git a/src/backends/inspectdr.jl b/src/backends/inspectdr.jl index 8cc2a22c..3eb8e5fc 100644 --- a/src/backends/inspectdr.jl +++ b/src/backends/inspectdr.jl @@ -13,7 +13,7 @@ Add in functionality to Plots.jl: :aspect_ratio, =# -@require Revise begin +@require Revise = "295af30f-e4ad-537b-8983-00126c2a3abe" begin Revise.track(Plots, joinpath(Pkg.dir("Plots"), "src", "backends", "inspectdr.jl")) end @@ -90,24 +90,24 @@ end # py_marker(markers::AVec) = map(py_marker, markers) function _inspectdr_mapglyph(markers::AVec) - warn("Vectors of markers are currently unsupported in InspectDR.") + @warn("Vectors of markers are currently unsupported in InspectDR.") _inspectdr_mapglyph(markers[1]) end _inspectdr_mapglyphsize(v::Real) = v function _inspectdr_mapglyphsize(v::Vector) - warn("Vectors of marker sizes are currently unsupported in InspectDR.") + @warn("Vectors of marker sizes are currently unsupported in InspectDR.") _inspectdr_mapglyphsize(v[1]) end _inspectdr_mapcolor(v::Colorant) = v function _inspectdr_mapcolor(g::PlotUtils.ColorGradient) - warn("Color gradients are currently unsupported in InspectDR.") + @warn("Color gradients are currently unsupported in InspectDR.") #Pick middle color: _inspectdr_mapcolor(g.colors[div(1+end,2)]) end function _inspectdr_mapcolor(v::AVec) - warn("Vectors of colors are currently unsupported in InspectDR.") + @warn("Vectors of colors are currently unsupported in InspectDR.") #Pick middle color: _inspectdr_mapcolor(v[div(1+end,2)]) end @@ -166,13 +166,13 @@ function _initialize_backend(::InspectDRBackend; kw...) export InspectDR #Glyph used when plotting "Shape"s: - const INSPECTDR_GLYPH_SHAPE = InspectDR.GlyphPolyline( + INSPECTDR_GLYPH_SHAPE = InspectDR.GlyphPolyline( 2*InspectDR.GLYPH_SQUARE.x, InspectDR.GLYPH_SQUARE.y ) mutable struct InspecDRPlotRef - mplot::Union{Void, InspectDR.Multiplot} - gui::Union{Void, InspectDR.GtkPlot} + mplot::Union{Nothing, InspectDR.Multiplot} + gui::Union{Nothing, InspectDR.GtkPlot} end _inspectdr_getmplot(::Any) = nothing @@ -347,8 +347,8 @@ end # --------------------------------------------------------------------------- function _inspectdr_setupsubplot(sp::Subplot{InspectDRBackend}) - const plot = sp.o - const strip = plot.strips[1] #Only 1 strip supported with Plots.jl + plot = sp.o + strip = plot.strips[1] #Only 1 strip supported with Plots.jl xaxis = sp[:xaxis]; yaxis = sp[:yaxis] xgrid_show = xaxis[:grid] @@ -406,7 +406,7 @@ end # called just before updating layout bounding boxes... in case you need to prep # for the calcs function _before_layout_calcs(plt::Plot{InspectDRBackend}) - const mplot = _inspectdr_getmplot(plt.o) + mplot = _inspectdr_getmplot(plt.o) if nothing == mplot; return; end mplot.title = plt[:plot_title] @@ -506,7 +506,7 @@ const _inspectdr_mimeformats_nodpi = Dict( # "application/postscript" => "ps", #TODO: support once Cairo supports PSSurface "application/pdf" => "pdf" ) -_inspectdr_show(io::IO, mime::MIME, ::Void, w, h) = +_inspectdr_show(io::IO, mime::MIME, ::Nothing, w, h) = throw(ErrorException("Cannot show(::IO, ...) plot - not yet generated")) function _inspectdr_show(io::IO, mime::MIME, mplot, w, h) InspectDR._show(io, mime, mplot, Float64(w), Float64(h)) diff --git a/src/backends/pgfplots.jl b/src/backends/pgfplots.jl index aae1a356..ab5f8bee 100644 --- a/src/backends/pgfplots.jl +++ b/src/backends/pgfplots.jl @@ -2,7 +2,7 @@ # significant contributions by: @pkofod -@require Revise begin +@require Revise = "295af30f-e4ad-537b-8983-00126c2a3abe" begin Revise.track(Plots, joinpath(Pkg.dir("Plots"), "src", "backends", "pgfplots.jl")) end @@ -426,11 +426,12 @@ function pgf_axis(sp::Subplot, letter) push!(style, string(letter, "tick = {", join(tick_values,","), "}")) if axis[:showaxis] && axis[:scale] in (:ln, :log2, :log10) && axis[:ticks] == :auto # wrap the power part of label with } - tick_labels = String[begin + tick_labels = Vector{String}(length(ticks[2])) + for (i, label) in enumerate(ticks[2]) base, power = split(label, "^") power = string("{", power, "}") - string(base, "^", power) - end for label in ticks[2]] + tick_labels[i] = string(base, "^", power) + end push!(style, string(letter, "ticklabels = {\$", join(tick_labels,"\$,\$"), "\$}")) elseif axis[:showaxis] tick_labels = ispolar(sp) && letter == :x ? [ticks[2][3:end]..., "0", "45"] : ticks[2] @@ -504,7 +505,7 @@ function _update_plot_object(plt::Plot{PGFPlotsBackend}) bb = bbox(sp) push!(style, """ xshift = $(left(bb).value)mm, - yshift = $(round((total_height - (bottom(bb))).value,2))mm, + yshift = $(round((total_height - (bottom(bb))).value, digits=2))mm, axis background/.style={fill=$(pgf_color(sp[:background_color_inside])[1])} """) kw[:width] = "$(width(bb).value)mm" @@ -607,7 +608,7 @@ function _show(io::IO, mime::MIME"application/pdf", plt::Plot{PGFPlotsBackend}) PGFPlots.save(PGFPlots.PDF(fn), pgfplt) # read it into io - write(io, readstring(open(fn))) + write(io, read(open(fn), String)) # cleanup PGFPlots.cleanup(plt.o) @@ -616,7 +617,7 @@ end function _show(io::IO, mime::MIME"application/x-tex", plt::Plot{PGFPlotsBackend}) fn = tempname()*".tex" PGFPlots.save(fn, backend_object(plt), include_preamble=false) - write(io, readstring(open(fn))) + write(io, read(open(fn), String)) end function _display(plt::Plot{PGFPlotsBackend}) diff --git a/src/backends/plotly.jl b/src/backends/plotly.jl index 333a4276..0b4c44d4 100644 --- a/src/backends/plotly.jl +++ b/src/backends/plotly.jl @@ -1,7 +1,7 @@ # https://plot.ly/javascript/getting-started -@require Revise begin +@require Revise = "295af30f-e4ad-537b-8983-00126c2a3abe" begin Revise.track(Plots, joinpath(Pkg.dir("Plots"), "src", "backends", "plotly.jl")) end @@ -450,7 +450,7 @@ function plotly_colorscale(c::AbstractVector{<:RGBA}, α) if length(c) == 1 return [[0.0, rgba_string(plot_color(c[1], α))], [1.0, rgba_string(plot_color(c[1], α))]] else - vals = linspace(0.0, 1.0, length(c)) + vals = range(0.0, stop=1.0, length=length(c)) return [[vals[i], rgba_string(plot_color(c[i], α))] for i in eachindex(c)] end end diff --git a/src/backends/plotlyjs.jl b/src/backends/plotlyjs.jl index e2883220..a371888c 100644 --- a/src/backends/plotlyjs.jl +++ b/src/backends/plotlyjs.jl @@ -1,4 +1,4 @@ -@require Revise begin +@require Revise = "295af30f-e4ad-537b-8983-00126c2a3abe" begin Revise.track(Plots, joinpath(Pkg.dir("Plots"), "src", "backends", "plotlyjs.jl")) end @@ -120,7 +120,7 @@ function _display(plt::Plot{PlotlyJSBackend}) end end -@require WebIO begin +@require WebIO = "0f1e0344-ec1d-5b48-a673-e5cf874b6c29" begin function WebIO.render(plt::Plot{PlotlyJSBackend}) prepare_output(plt) WebIO.render(plt.o) diff --git a/src/backends/pyplot.jl b/src/backends/pyplot.jl index fa86acc3..5338eedf 100644 --- a/src/backends/pyplot.jl +++ b/src/backends/pyplot.jl @@ -1,7 +1,7 @@ # https://github.com/stevengj/PyPlot.jl -@require Revise begin +@require Revise = "295af30f-e4ad-537b-8983-00126c2a3abe" begin Revise.track(Plots, joinpath(Pkg.dir("Plots"), "src", "backends", "pyplot.jl")) end @@ -82,21 +82,21 @@ function _initialize_backend(::PyPlotBackend) append!(Base.Multimedia.displays, otherdisplays) export PyPlot - const pycolors = PyPlot.pyimport("matplotlib.colors") - const pypath = PyPlot.pyimport("matplotlib.path") - const mplot3d = PyPlot.pyimport("mpl_toolkits.mplot3d") - const pypatches = PyPlot.pyimport("matplotlib.patches") - const pyfont = PyPlot.pyimport("matplotlib.font_manager") - const pyticker = PyPlot.pyimport("matplotlib.ticker") - const pycmap = PyPlot.pyimport("matplotlib.cm") - const pynp = PyPlot.pyimport("numpy") + pycolors = PyPlot.pyimport("matplotlib.colors") + pypath = PyPlot.pyimport("matplotlib.path") + mplot3d = PyPlot.pyimport("mpl_toolkits.mplot3d") + pypatches = PyPlot.pyimport("matplotlib.patches") + pyfont = PyPlot.pyimport("matplotlib.font_manager") + pyticker = PyPlot.pyimport("matplotlib.ticker") + pycmap = PyPlot.pyimport("matplotlib.cm") + pynp = PyPlot.pyimport("numpy") pynp["seterr"](invalid="ignore") - const pytransforms = PyPlot.pyimport("matplotlib.transforms") - const pycollections = PyPlot.pyimport("matplotlib.collections") - const pyart3d = PyPlot.art3D + pytransforms = PyPlot.pyimport("matplotlib.transforms") + pycollections = PyPlot.pyimport("matplotlib.collections") + pyart3d = PyPlot.art3D # "support" matplotlib v1.5 - const set_facecolor_sym = if PyPlot.version < v"2" + set_facecolor_sym = if PyPlot.version < v"2" warn("You are using Matplotlib $(PyPlot.version), which is no longer officialy supported by the Plots community. To ensure smooth Plots.jl integration update your Matplotlib library to a version >= 2.0.0") :set_axis_bgcolor else @@ -679,8 +679,8 @@ function py_add_series(plt::Plot{PyPlotBackend}, series::Series) if typeof(z) <: AbstractMatrix || typeof(z) <: Surface x, y, z = map(Array, (x,y,z)) if !ismatrix(x) || !ismatrix(y) - x = repmat(x', length(y), 1) - y = repmat(y, 1, length(series[:x])) + x = repeat(x', length(y), 1) + y = repeat(y, 1, length(series[:x])) end z = transpose_z(series, z) if st == :surface @@ -919,7 +919,7 @@ function py_set_scale(ax, axis::Axis) "linear" else kw[Symbol(:base,letter)] = if scale == :ln - e + ℯ elseif scale == :log2 2 elseif scale == :log10 diff --git a/src/backends/unicodeplots.jl b/src/backends/unicodeplots.jl index f644966d..4ed936cb 100644 --- a/src/backends/unicodeplots.jl +++ b/src/backends/unicodeplots.jl @@ -1,7 +1,7 @@ # https://github.com/Evizero/UnicodePlots.jl -@require Revise begin +@require Revise = "295af30f-e4ad-537b-8983-00126c2a3abe" begin Revise.track(Plots, joinpath(Pkg.dir("Plots"), "src", "backends", "unicodeplots.jl")) end @@ -183,7 +183,7 @@ function png(plt::AbstractPlot{UnicodePlotsBackend}, fn::AbstractString) gui(plt) # @osx_only begin - @static if is_apple() + @static if Sys.isapple() # BEGIN HACK # wait while the plot gets drawn diff --git a/src/backends/web.jl b/src/backends/web.jl index e38ad782..bb39a91d 100644 --- a/src/backends/web.jl +++ b/src/backends/web.jl @@ -2,8 +2,8 @@ # NOTE: backend should implement `html_body` and `html_head` # CREDIT: parts of this implementation were inspired by @joshday's PlotlyLocal.jl -@require Revise begin - Revise.track(Plots, joinpath(Pkg.dir("Plots"), "src", "backends", "web.jl")) +@require Revise = "295af30f-e4ad-537b-8983-00126c2a3abe" begin + Revise.track(Plots, joinpath(Pkg.dir("Plots"), "src", "backends", "web.jl")) end function standalone_html(plt::AbstractPlot; title::AbstractString = get(plt.attr, :window_title, "Plots.jl")) @@ -23,16 +23,16 @@ function standalone_html(plt::AbstractPlot; title::AbstractString = get(plt.attr end function open_browser_window(filename::AbstractString) - @static if is_apple() + @static if Sys.isapple() return run(`open $(filename)`) end - @static if is_linux() || is_bsd() # is_bsd() addition is as yet untested, but based on suggestion in https://github.com/JuliaPlots/Plots.jl/issues/681 + @static if Sys.islinux() || is_bsd() # is_bsd() addition is as yet untested, but based on suggestion in https://github.com/JuliaPlots/Plots.jl/issues/681 return run(`xdg-open $(filename)`) end - @static if is_windows() + @static if Sys.iswindows() return run(`$(ENV["COMSPEC"]) /c start "" "$(filename)"`) end - warn("Unknown OS... cannot open browser window.") + @warn("Unknown OS... cannot open browser window.") end function write_temp_html(plt::AbstractPlot) diff --git a/src/components.jl b/src/components.jl index 2b1284ce..8ca11574 100644 --- a/src/components.jl +++ b/src/components.jl @@ -58,7 +58,7 @@ end "get an array of tuples of points on a circle with radius `r`" function partialcircle(start_θ, end_θ, n = 20, r=1) - Tuple{Float64,Float64}[(r*cos(u),r*sin(u)) for u in linspace(start_θ, end_θ, n)] + Tuple{Float64,Float64}[(r*cos(u),r*sin(u)) for u in range(start_θ, stop=end_θ, length=n)] end "interleave 2 vectors into each other (like a zipper's teeth)" @@ -68,7 +68,8 @@ function weave(x,y; ordering = Vector[x,y]) while !done for o in ordering try - push!(ret, shift!(o)) + push!(ret, popfirst!(o)) + catch end end done = isempty(x) && isempty(y) @@ -388,6 +389,7 @@ function stroke(args...; alpha = nothing) elseif T <: Symbol || T <: AbstractString try color = parse(Colorant, string(arg)) + catch end elseif allAlphas(arg) alpha = arg @@ -420,6 +422,7 @@ function brush(args...; alpha = nothing) elseif T <: Symbol || T <: AbstractString try color = parse(Colorant, string(arg)) + catch end elseif allAlphas(arg) alpha = arg @@ -438,16 +441,16 @@ end mutable struct SeriesAnnotations strs::AbstractVector # the labels/names font::Font - baseshape::Nullable + baseshape::Union{Shape, AbstractVector{Shape}, Nothing} scalefactor::Tuple end function series_annotations(strs::AbstractVector, args...) fnt = font() - shp = Nullable{Any}() + shp = nothing scalefactor = (1,1) for arg in args if isa(arg, Shape) || (isa(arg, AbstractVector) && eltype(arg) == Shape) - shp = Nullable(arg) + shp = arg elseif isa(arg, Font) fnt = arg elseif isa(arg, Symbol) && haskey(_shapes, arg) @@ -468,7 +471,7 @@ function series_annotations(strs::AbstractVector, args...) SeriesAnnotations(strs, fnt, shp, scalefactor) end series_annotations(anns::SeriesAnnotations) = anns -series_annotations(::Void) = nothing +series_annotations(::Nothing) = nothing function series_annotations_shapes!(series::Series, scaletype::Symbol = :pixels) anns = series[:series_annotations] @@ -483,12 +486,13 @@ function series_annotations_shapes!(series::Series, scaletype::Symbol = :pixels) # end # @show msw msh - if anns != nothing && !isnull(anns.baseshape) + if anns != nothing && anns.baseshape != nothing # we use baseshape to overwrite the markershape attribute # with a list of custom shapes for each msw,msh = anns.scalefactor msize = Float64[] - shapes = Shape[begin + shapes = Vector{Shape}(length(anns.strs)) + for i in eachindex(anns.strs) str = _cycle(anns.strs,i) # get the width and height of the string (in mm) @@ -506,8 +510,8 @@ function series_annotations_shapes!(series::Series, scaletype::Symbol = :pixels) maxscale = max(xscale, yscale) push!(msize, maxscale) baseshape = _cycle(get(anns.baseshape),i) - shape = scale(baseshape, msw*xscale/maxscale, msh*yscale/maxscale, (0,0)) - end for i=1:length(anns.strs)] + shapes[i] = scale(baseshape, msw*xscale/maxscale, msh*yscale/maxscale, (0,0)) + end series[:markershape] = shapes series[:markersize] = msize end @@ -531,7 +535,7 @@ function Base.next(ea::EachAnn, i) ((_cycle(ea.x,i), _cycle(ea.y,i), str, fnt), i+1) end -annotations(::Void) = [] +annotations(::Nothing) = [] annotations(anns::AVec) = anns annotations(anns) = Any[anns] annotations(sa::SeriesAnnotations) = sa @@ -747,7 +751,7 @@ end @deprecate curve_points coords -coords(curve::BezierCurve, n::Integer = 30; range = [0,1]) = map(curve, linspace(range..., n)) +coords(curve::BezierCurve, n::Integer = 30; range = [0,1]) = map(curve, range(range..., stop=n, length=50)) # build a BezierCurve which leaves point p vertically upwards and arrives point q vertically upwards. # may create a loop if necessary. Assumes the view is [0,1] diff --git a/src/deprecated/backends/bokeh.jl b/src/deprecated/backends/bokeh.jl index 4963d206..924c20f2 100644 --- a/src/deprecated/backends/bokeh.jl +++ b/src/deprecated/backends/bokeh.jl @@ -72,7 +72,7 @@ is_subplot_supported(::BokehBackend) = false function _initialize_backend(::BokehBackend; kw...) @eval begin - warn("Bokeh is no longer supported... many features will likely be broken.") + @warn("Bokeh is no longer supported... many features will likely be broken.") import Bokeh export Bokeh end @@ -196,7 +196,7 @@ end function Base.show(io::IO, ::MIME"image/png", plt::AbstractPlot{BokehBackend}) # TODO: write a png to io - warn("mime png not implemented") + @warn("mime png not implemented") end function Base.display(::PlotsDisplay, plt::Plot{BokehBackend}) diff --git a/src/deprecated/backends/gadfly.jl b/src/deprecated/backends/gadfly.jl index 53453b9e..906532a1 100644 --- a/src/deprecated/backends/gadfly.jl +++ b/src/deprecated/backends/gadfly.jl @@ -244,7 +244,7 @@ function addToGadflyLegend(plt::Plot, d::KW) # add the legend if needed if all(g -> !isa(g, Gadfly.Guide.ManualColorKey), gplt.guides) - unshift!(gplt.guides, Gadfly.Guide.manual_color_key("", AbstractString[], Color[])) + pushfirst!(gplt.guides, Gadfly.Guide.manual_color_key("", AbstractString[], Color[])) end # now add the series to the legend diff --git a/src/deprecated/backends/qwt.jl b/src/deprecated/backends/qwt.jl index 6bffd322..6f7fefcb 100644 --- a/src/deprecated/backends/qwt.jl +++ b/src/deprecated/backends/qwt.jl @@ -31,7 +31,7 @@ is_subplot_supported(::QwtBackend) = true function _initialize_backend(::QwtBackend; kw...) @eval begin - warn("Qwt is no longer supported... many features will likely be broken.") + @warn("Qwt is no longer supported... many features will likely be broken.") import Qwt export Qwt end @@ -142,7 +142,7 @@ function updateLimsAndTicks(plt::Plot{QwtBackend}, d::KW, isx::Bool) w[:setAxisScale](axisid, lims...) end - if typeof(ticks) <: Range + if typeof(ticks) <: AbstractRange if isx plt.o.autoscale_x = false else diff --git a/src/deprecated/backends/winston.jl b/src/deprecated/backends/winston.jl index 22694be8..ead18b6b 100644 --- a/src/deprecated/backends/winston.jl +++ b/src/deprecated/backends/winston.jl @@ -34,7 +34,7 @@ is_subplot_supported(::WinstonBackend) = false function _initialize_backend(::WinstonBackend; kw...) @eval begin # ENV["WINSTON_OUTPUT"] = "gtk" - warn("Winston is no longer supported... many features will likely be broken.") + @warn("Winston is no longer supported... many features will likely be broken.") import Winston, Gtk export Winston, Gtk end diff --git a/src/deprecated/color_gradients.jl b/src/deprecated/color_gradients.jl index 37e7c4ef..5516ac06 100644 --- a/src/deprecated/color_gradients.jl +++ b/src/deprecated/color_gradients.jl @@ -19,7 +19,7 @@ # work. If not, see . function sample_evenly(v::AVec, n::Integer = length(v)) - idx = Int[round(Int, x) for x in linspace(1, length(v), n)] + idx = Int[round(Int, x) for x in range(1, stop=length(v), length=n)] v[idx] end diff --git a/src/deprecated/colors.jl b/src/deprecated/colors.jl index 8247529a..4646934a 100644 --- a/src/deprecated/colors.jl +++ b/src/deprecated/colors.jl @@ -13,15 +13,15 @@ function cgrad(arg, values = nothing; alpha = nothing, scale = :identity) values = if values != nothing values elseif scale in (:log, :log10) - log10(linspace(1,10,30)) + log10(range(1, stop=10, length=30)) elseif scale == :log2 - log2(linspace(1,2,30)) + log2(range(1, stop=2, length=30)) elseif scale == :ln - log(linspace(1,pi,30)) + log(range(1, stop=pi, length=30)) elseif scale in (:exp, :exp10) - (exp10(linspace(0,1,30)) - 1) / 9 + (exp10(range(0, stop=1, length=30)) - 1) / 9 else - linspace(0, 1, length(colors)) + range(0, stop=1, length=length(colors)) end ColorGradient(colors, values) end @@ -51,7 +51,7 @@ convertColor(c::Symbol) = parse(Colorant, string(c)) convertColor(c::Colorant) = c convertColor(cvec::AbstractVector) = map(convertColor, cvec) convertColor(c::ColorScheme) = c -convertColor(v::Void) = RGBA(0,0,0,0) +convertColor(v::Nothing) = RGBA(0,0,0,0) convertColor(b::Bool) = b ? RGBA(0,0,0,1) : RGBA(0,0,0,0) function convertColor(c, α::Real) @@ -59,7 +59,7 @@ function convertColor(c, α::Real) RGBA(RGB(getColor(c)), α) end convertColor(cs::AVec, α::Real) = map(c -> convertColor(c, α), cs) -convertColor(c, α::Void) = convertColor(c) +convertColor(c, α::Nothing) = convertColor(c) # backup... try to convert getColor(c) = convertColor(c) @@ -113,7 +113,7 @@ struct ColorGradient <: ColorScheme colors::Vector values::Vector - function ColorGradient(cs::AVec, vals::AVec{S} = linspace(0, 1, length(cs)); alpha = nothing) where S<:Real + function ColorGradient(cs::AVec, vals::AVec{S} = range(0, stop=1, length=length(cs)); alpha = nothing) where S<:Real if length(cs) == length(vals) return new(convertColor(cs,alpha), collect(vals)) end @@ -124,9 +124,9 @@ struct ColorGradient <: ColorScheme # new(convertColor(cs,alpha), vs) # interpolate the colors for each value - vals = merge(linspace(0, 1, length(cs)), vals) + vals = merge(range(0, stop=1, length=length(cs)), vals) grad = ColorGradient(cs) - cs = [getColorZ(grad, z) for z in linspace(0, 1, length(vals))] + cs = [getColorZ(grad, z) for z in range(0, stop=1, length=length(vals))] new(convertColor(cs, alpha), vals) end end @@ -142,7 +142,7 @@ function ColorGradient(s::Symbol, vals::AVec{T} = 0:0; kw...) where T<:Real haskey(_gradients, s) || error("Invalid gradient symbol. Choose from: ", sort(collect(keys(_gradients)))) cs = _gradients[s] if vals == 0:0 - vals = linspace(0, 1, length(cs)) + vals = range(0, stop=1, length=length(cs)) end ColorGradient(cs, vals; kw...) end @@ -247,7 +247,7 @@ ColorWrapper(s::Symbol; alpha = nothing) = ColorWrapper(convertColor(parse(Color getColor(scheme::ColorWrapper, idx::Int) = scheme.c getColorZ(scheme::ColorWrapper, z::Real) = scheme.c -convertColor(c::ColorWrapper, α::Void) = c.c +convertColor(c::ColorWrapper, α::Nothing) = c.c # -------------------------------------------------------------- @@ -332,7 +332,7 @@ function generate_colorgradient(bgcolor = colorant"white"; seed_colors, lchoices=Float64[lightness], cchoices=Float64[chroma], - hchoices=linspace(0, 340, 20) + hchoices=range(0, stop=340, length=20) )[2:end] gradient_from_list(colors) end diff --git a/src/deprecated/series_args.jl b/src/deprecated/series_args.jl index b5b02594..8a60bf5c 100644 --- a/src/deprecated/series_args.jl +++ b/src/deprecated/series_args.jl @@ -10,7 +10,7 @@ const FuncOrFuncs = Union{Function, AVec{Function}} all3D(d::KW) = trueOrAllTrue(st -> st in (:contour, :contourf, :heatmap, :surface, :wireframe, :contour3d, :image), get(d, :seriestype, :none)) # missing -convertToAnyVector(v::Void, d::KW) = Any[nothing], nothing +convertToAnyVector(v::Nothing, d::KW) = Any[nothing], nothing # fixed number of blank series convertToAnyVector(n::Integer, d::KW) = Any[zeros(0) for i in 1:n], nothing @@ -65,19 +65,19 @@ end # TODO: can we avoid the copy here? one error that crops up is that mapping functions over the same array # result in that array being shared. push!, etc will add too many items to that array -compute_x(x::Void, y::Void, z) = 1:size(z,1) -compute_x(x::Void, y, z) = 1:size(y,1) +compute_x(x::Nothing, y::Nothing, z) = 1:size(z,1) +compute_x(x::Nothing, y, z) = 1:size(y,1) compute_x(x::Function, y, z) = map(x, y) compute_x(x, y, z) = copy(x) # compute_y(x::Void, y::Function, z) = error() -compute_y(x::Void, y::Void, z) = 1:size(z,2) +compute_y(x::Nothing, y::Nothing, z) = 1:size(z,2) compute_y(x, y::Function, z) = map(y, x) compute_y(x, y, z) = copy(y) compute_z(x, y, z::Function) = map(z, x, y) compute_z(x, y, z::AbstractMatrix) = Surface(z) -compute_z(x, y, z::Void) = nothing +compute_z(x, y, z::Nothing) = nothing compute_z(x, y, z) = copy(z) nobigs(v::AVec{BigFloat}) = map(Float64, v) @@ -92,8 +92,8 @@ nobigs(v) = v end # not allowed -compute_xyz(x::Void, y::FuncOrFuncs, z) = error("If you want to plot the function `$y`, you need to define the x values!") -compute_xyz(x::Void, y::Void, z::FuncOrFuncs) = error("If you want to plot the function `$z`, you need to define x and y values!") -compute_xyz(x::Void, y::Void, z::Void) = error("x/y/z are all nothing!") +compute_xyz(x::Nothing, y::FuncOrFuncs, z) = error("If you want to plot the function `$y`, you need to define the x values!") +compute_xyz(x::Nothing, y::Nothing, z::FuncOrFuncs) = error("If you want to plot the function `$z`, you need to define x and y values!") +compute_xyz(x::Nothing, y::Nothing, z::Nothing) = error("x/y/z are all nothing!") # -------------------------------------------------------------------- diff --git a/src/examples.jl b/src/examples.jl index 57ed7b3e..ee362741 100644 --- a/src/examples.jl +++ b/src/examples.jl @@ -29,7 +29,7 @@ animation. [:(begin p = plot([sin,cos], zeros(0), leg=false) anim = Animation() - for x in linspace(0, 10π, 100) + for x in range(0, stop=10π, length=100) push!(p, x, Float64[sin(x), cos(x)]) frame(anim) end @@ -52,7 +52,7 @@ the `z` argument to turn on series gradients. [:(begin y = rand(100) plot(0:10:100,rand(11,4),lab="lines",w=3,palette=:grays,fill=0, α=0.6) -scatter!(y, zcolor=abs.(y-.5), m=(:heat,0.8,stroke(1,:green)), ms=10*abs.(y-0.5)+4, +scatter!(y, zcolor=abs.(y.-0.5), m=(:heat,0.8,stroke(1,:green)), ms=10*abs.(y.-0.5).+4, lab="grad") end)] ), @@ -69,7 +69,7 @@ the preprocessing step. You can also use shorthand functions: `title!`, `xaxis!` y = rand(20,3) plot(y, xaxis=("XLABEL",(-5,30),0:2:20,:flip), background_color = RGB(0.2,0.2,0.2), leg=false) -hline!(mean(y,1)+rand(1,3), line=(4,:dash,0.6,[:lightgreen :green :darkgreen])) +hline!(mean(y, dims = 1)+rand(1,3), line=(4,:dash,0.6,[:lightgreen :green :darkgreen])) vline!([5,10]) title!("TITLE") yaxis!("YLABEL", :log10) @@ -145,7 +145,7 @@ styles = filter(s -> s in Plots.supported_styles(), [:solid, :dash, :dot, :dashdot, :dashdotdot]) styles = reshape(styles, 1, length(styles)) # Julia 0.6 unfortunately gives an error when transposing symbol vectors n = length(styles) -y = cumsum(randn(20,n),1) +y = cumsum(randn(20,n), dims = 1) plot(y, line = (5, styles), label = map(string,styles), legendtitle = "linestyle") end)] ), @@ -156,8 +156,8 @@ PlotExample("Marker types", markers = filter(m -> m in Plots.supported_markers(), Plots._shape_keys) markers = reshape(markers, 1, length(markers)) n = length(markers) - x = linspace(0,10,n+2)[2:end-1] - y = repmat(reshape(reverse(x),1,:), n, 1) + x = range(0, stop=10, length=n+2)[2:end-1] + y = repeat(reshape(reverse(x),1,:), n, 1) scatter(x, y, m=(8,:auto), lab=map(string,markers), bg=:linen, xlim=(0,10), ylim=(0,10)) end)] ), @@ -202,7 +202,7 @@ plot(Plots.fakedata(100,10), layout=4, palette=[:grays :blues :heat :lightrainbo PlotExample("", "", [:(begin - srand(111) + Random.srand(111) plot!(Plots.fakedata(100,10)) end)] ), @@ -215,7 +215,7 @@ subsequently create a :path series with the appropriate line segments. """, [:(begin n=20 -hgt=rand(n)+1 +hgt=rand(n).+1 bot=randn(n) openpct=rand(n) closepct=rand(n) @@ -238,7 +238,7 @@ y = rand(10) plot(y, annotations = (3,y[3],text("this is #3",:left)), leg=false) annotate!([(5, y[5], text("this is #5",16,:red,:center)), (10, y[10], text("this is #10",:right,20,"courier"))]) -scatter!(linspace(2,8,6), rand(6), marker=(50,0.2,:orange), +scatter!(range(2, stop=8, length=6), rand(6), marker=(50,0.2,:orange), series_annotations = ["series","annotations","map","to","series", text("data",:green)]) end)] @@ -254,7 +254,7 @@ verts = [(-1.0,1.0),(-1.28,0.6),(-0.2,-1.4),(0.2,-1.4),(1.28,0.6),(1.0,1.0), (-1.0,1.0),(-0.2,-0.6),(0.0,-0.2),(-0.4,0.6),(1.28,0.6),(0.2,-1.4), (-0.2,-1.4),(0.6,0.2),(-0.2,0.2),(0.0,-0.2),(0.2,0.2),(-0.2,-0.6)] x = 0.1:0.2:0.9 -y = 0.7rand(5)+0.15 +y = 0.7rand(5).+0.15 plot(x, y, line = (3,:dash,:lightblue), marker = (Shape(verts),30,RGBA(0,0,0,0.2)), bg=:pink, fg=:darkblue, xlim = (0,1), ylim=(0,1), leg=false) end)] @@ -269,8 +269,8 @@ unfilled contour from a matrix. x = 1:0.5:20 y = 1:0.5:10 f(x,y) = (3x+y^2)*abs(sin(x)+cos(y)) - X = repmat(reshape(x,1,:), length(y), 1) - Y = repmat(y, 1, length(x)) + X = repeat(reshape(x,1,:), length(y), 1) + Y = repeat(y, 1, length(x)) Z = map(f, X, Y) p1 = contour(x, y, f, fill=true) p2 = contour(x, y, Z) @@ -291,7 +291,7 @@ PlotExample("3D", "", [:(begin n = 100 - ts = linspace(0,8π,n) + ts = range(0, stop=8π, length=n) x = ts .* map(cos,ts) y = 0.1ts .* map(sin,ts) z = 1:n @@ -323,7 +323,7 @@ PlotExample("Groups and Subplots", PlotExample("Polar Plots", "", [:(begin - Θ = linspace(0,1.5π,100) + Θ = range(0, stop=1.5π, length=100) r = abs.(0.1randn(100)+sin.(3Θ)) plot(Θ, r, proj=:polar, m=2) end)] @@ -368,7 +368,7 @@ PlotExample("Animation with subplots", plot(log,1,xlims=(1,10π),ylims=(0,5),leg=false),layout=l) anim = Animation() - for x = linspace(1,10π,100) + for x = range(1, stop=10π, length=100) plot(push!(p,x,Float64[sin(x),cos(x),atan(x),cos(x),log(x)])) frame(anim) end @@ -377,8 +377,8 @@ PlotExample("Animation with subplots", PlotExample("Spy", """ -For a matrix `mat` with unique nonzeros `spy(mat)` returns a colorless plot. If `mat` has -various different nonzero values, a colorbar is added. The colorbar can be disabled with +For a matrix `mat` with unique nonzeros `spy(mat)` returns a colorless plot. If `mat` has +various different nonzero values, a colorbar is added. The colorbar can be disabled with `legend = nothing`. """, [:(begin @@ -419,10 +419,10 @@ attribute. The default framestyle is `:axes`. PlotExample("Lines and markers with varying colors", """ You can use the `line_z` and `marker_z` properties to associate a color with -each line segment or marker in the plot. +each line segment or marker in the plot. """, [:(begin - t = linspace(0, 1, 100) + t = range(0, stop=1, length=100) θ = 6π .* t x = t .* cos.(θ) y = t .* sin.(θ) @@ -439,7 +439,7 @@ each line segment or marker in the plot. # make and display one plot function test_examples(pkgname::Symbol, idx::Int; debug = false, disp = true) Plots._debugMode.on = debug - info("Testing plot: $pkgname:$idx:$(_examples[idx].header)") + @info("Testing plot: $pkgname:$idx:$(_examples[idx].header)") backend(pkgname) backend() map(eval, _examples[idx].exprs) diff --git a/src/layouts.jl b/src/layouts.jl index 63924374..8999cf62 100644 --- a/src/layouts.jl +++ b/src/layouts.jl @@ -268,7 +268,7 @@ function GridLayout(dims...; widths = zeros(dims[2]), heights = zeros(dims[1]), kw...) - grid = Matrix{AbstractLayout}(dims...) + grid = Matrix{AbstractLayout}(undef, dims...) layout = GridLayout( parent, (20mm, 5mm, 2mm, 10mm), @@ -357,10 +357,10 @@ function update_child_bboxes!(layout::GridLayout, minimum_perimeter = [0mm,0mm,0 # get the max horizontal (left and right) padding over columns, # and max vertical (bottom and top) padding over rows # TODO: add extra padding here - pad_left = maximum(minpad_left, 1) - pad_top = maximum(minpad_top, 2) - pad_right = maximum(minpad_right, 1) - pad_bottom = maximum(minpad_bottom, 2) + pad_left = maximum(minpad_left, dims = 1) + pad_top = maximum(minpad_top, dims = 2) + pad_right = maximum(minpad_right, dims = 1) + pad_bottom = maximum(minpad_bottom, dims = 2) # make sure the perimeter match the parent pad_left[1] = max(pad_left[1], minimum_perimeter[1]) @@ -566,7 +566,7 @@ function build_layout(layout::GridLayout, numsp::Integer, plts::AVec{Plot}) for r=1:nr, c=1:nc l = layout[r,c] if isa(l, EmptyLayout) && !get(l.attr, :blank, false) - plt = shift!(plts) # grab the first plot out of the list + plt = popfirst!(plts) # grab the first plot out of the list layout[r,c] = plt.layout append!(subplots, plt.subplots) merge!(spmap, plt.spmap) diff --git a/src/output.jl b/src/output.jl index 1f9da687..c4dec4f4 100644 --- a/src/output.jl +++ b/src/output.jl @@ -146,7 +146,8 @@ function Base.display(::PlotsDisplay, plt::Plot) end # override the REPL display to open a gui window -Base.display(::Base.REPL.REPLDisplay, ::MIME"text/plain", plt::Plot) = gui(plt) +using REPL +Base.display(::REPL.REPLDisplay, ::MIME"text/plain", plt::Plot) = gui(plt) _do_plot_show(plt, showval::Bool) = showval && gui(plt) @@ -186,11 +187,11 @@ end # delegate mimewritable (showable on julia 0.7) to _show instead function Base.mimewritable(m::M, plt::P) where {M<:MIME, P<:Plot} - return method_exists(_show, Tuple{IO, M, P}) + return hasmethod(_show, Tuple{IO, M, P}) end function _display(plt::Plot) - warn("_display is not defined for this backend.") + @warn("_display is not defined for this backend.") end # for writing to io streams... first prepare, then callback @@ -230,7 +231,7 @@ if is_installed("FileIO") FileIO.save(pngfn, s) # now write from the file - write(io, readstring(open(pngfn))) + write(io, read(open(pngfn), String)) end end @@ -254,7 +255,7 @@ end # IJulia # --------------------------------------------------------- -@require IJulia begin +@require IJulia = "7073ff75-c697-5162-941a-fcdaad2a7d2a" begin if IJulia.inited """ @@ -310,7 +311,7 @@ end # --------------------------------------------------------- # Atom PlotPane # --------------------------------------------------------- -@require Juno begin +@require Juno = "e5e0dc1b-0480-54bc-9374-aad01c23163d" begin import Hiccup, Media if Juno.isactive() diff --git a/src/pipeline.jl b/src/pipeline.jl index d1af402d..d4cb1f4a 100644 --- a/src/pipeline.jl +++ b/src/pipeline.jl @@ -11,11 +11,13 @@ function _expand_seriestype_array(d::KW, args) sts = get(d, :seriestype, :path) if typeof(sts) <: AbstractArray delete!(d, :seriestype) - RecipeData[begin + rd = Vector{RecipeData}(undef, size(sts, 1)) + for r in 1:size(sts, 1) dc = copy(d) dc[:seriestype] = sts[r:r,:] - RecipeData(dc, args) - end for r=1:size(sts,1)] + rd[r] = RecipeData(dc, args) + end + rd else RecipeData[RecipeData(copy(d), args)] end @@ -70,7 +72,7 @@ function _process_userrecipes(plt::Plot, d::KW, args) # grab the first in line to be processed and either add it to the kw_list or # pass it through apply_recipe to generate a list of RecipeData objects (data + attributes) # for further processing. - next_series = shift!(still_to_process) + next_series = popfirst!(still_to_process) # recipedata should be of type RecipeData. if it's not then the inputs must not have been fully processed by recipes if !(typeof(next_series) <: RecipeData) error("Inputs couldn't be processed... expected RecipeData but got: $next_series") @@ -151,7 +153,7 @@ function _add_smooth_kw(kw_list::Vector{KW}, kw::KW) x, y = kw[:x], kw[:y] β, α = convert(Matrix{Float64}, [x ones(length(x))]) \ convert(Vector{Float64}, y) sx = [ignorenan_minimum(x), ignorenan_maximum(x)] - sy = β * sx + α + sy = β .* sx .+ α push!(kw_list, merge(copy(kw), KW( :seriestype => :path, :x => sx, @@ -329,7 +331,7 @@ function _override_seriestype_check(d::KW, st::Symbol) # do we want to override the series type? if !is3d(st) && !(st in (:contour,:contour3d)) z = d[:z] - if !isa(z, Void) && (size(d[:x]) == size(d[:y]) == size(z)) + if !isa(z, Nothing) && (size(d[:x]) == size(d[:y]) == size(z)) st = (st == :scatter ? :scatter3d : :path3d) d[:seriestype] = st end diff --git a/src/plot.jl b/src/plot.jl index 2b7ab389..7e62b126 100644 --- a/src/plot.jl +++ b/src/plot.jl @@ -1,10 +1,10 @@ mutable struct CurrentPlot - nullableplot::Nullable{AbstractPlot} + nullableplot::Union{AbstractPlot, Nothing} end -const CURRENT_PLOT = CurrentPlot(Nullable{AbstractPlot}()) +const CURRENT_PLOT = CurrentPlot(nothing) -isplotnull() = isnull(CURRENT_PLOT.nullableplot) +isplotnull() = CURRENT_PLOT.nullableplot == nothing """ current() @@ -14,9 +14,9 @@ function current() if isplotnull() error("No current plot/subplot") end - get(CURRENT_PLOT.nullableplot) + CURRENT_PLOT.nullableplot end -current(plot::AbstractPlot) = (CURRENT_PLOT.nullableplot = Nullable(plot)) +current(plot::AbstractPlot) = (CURRENT_PLOT.nullableplot = plot) # --------------------------------------------------------- @@ -46,9 +46,8 @@ When you pass in matrices, it splits by columns. To see the list of available at function, where `attr` is the symbol `:Series:`, `:Subplot:`, `:Plot` or `:Axis`. Pass any attribute to `plotattr` as a String to look up its docstring; e.g. `plotattr("seriestype")`. """ - -# this creates a new plot with args/kw and sets it to be the current plot function plot(args...; kw...) + # this creates a new plot with args/kw and sets it to be the current plot d = KW(kw) preprocessArgs!(d) @@ -66,7 +65,7 @@ function plot(plt1::Plot, plts_tail::Plot...; kw...) # build our plot vector from the args n = length(plts_tail) + 1 - plts = Array{Plot}(n) + plts = Array{Plot}(undef, n) plts[1] = plt1 for (i,plt) in enumerate(plts_tail) plts[i+1] = plt @@ -169,7 +168,7 @@ function _plot!(plt::Plot, d::KW, args::Tuple) if !isempty(args) && !isdefined(Main, :StatPlots) && first(split(string(typeof(args[1])), ".")) == "DataFrames" - warn("You're trying to plot a DataFrame, but this functionality is provided by StatPlots") + @warn("You're trying to plot a DataFrame, but this functionality is provided by StatPlots") end # -------------------------------- @@ -193,7 +192,7 @@ function _plot!(plt::Plot, d::KW, args::Tuple) still_to_process = kw_list kw_list = KW[] while !isempty(still_to_process) - next_kw = shift!(still_to_process) + next_kw = popfirst!(still_to_process) _process_plotrecipe(plt, next_kw, kw_list, still_to_process) end diff --git a/src/recipes.jl b/src/recipes.jl index dfb1fd54..91f84fe5 100644 --- a/src/recipes.jl +++ b/src/recipes.jl @@ -80,7 +80,7 @@ end @recipe function f(::Type{Val{:hline}}, x, y, z) n = length(y) - newx = repmat(Float64[-1, 1, NaN], n) + newx = repeat(Float64[-1, 1, NaN], n) newy = vec(Float64[yi for i=1:3,yi=y]) x := newx y := newy @@ -92,7 +92,7 @@ end @recipe function f(::Type{Val{:vline}}, x, y, z) n = length(y) newx = vec(Float64[yi for i=1:3,yi=y]) - newy = repmat(Float64[-1, 1, NaN], n) + newy = repeat(Float64[-1, 1, NaN], n) x := newx y := newy seriestype := :straightline @@ -586,7 +586,7 @@ function _auto_binning_nbins(vs::NTuple{N,AbstractVector}, dim::Integer; mode::S _iqr(v) = (q = quantile(v, 0.75) - quantile(v, 0.25); q > 0 ? q : oftype(q, 1)) _span(v) = ignorenan_maximum(v) - ignorenan_minimum(v) - n_samples = length(linearindices(first(vs))) + n_samples = length(LinearIndices(first(vs))) # The nd estimator is the key to most automatic binning methods, and is modified for twodimensional histograms to include correlation nd = n_samples^(1/(2+N)) @@ -620,10 +620,10 @@ _hist_edge(vs::NTuple{N,AbstractVector}, dim::Integer, binning::Symbol) where {N _hist_edge(vs::NTuple{N,AbstractVector}, dim::Integer, binning::AbstractVector) where {N} = binning _hist_edges(vs::NTuple{N,AbstractVector}, binning::NTuple{N}) where {N} = - map(dim -> _hist_edge(vs, dim, binning[dim]), (1:N...)) + map(dim -> _hist_edge(vs, dim, binning[dim]), (1:N...,)) _hist_edges(vs::NTuple{N,AbstractVector}, binning::Union{Integer, Symbol, AbstractVector}) where {N} = - map(dim -> _hist_edge(vs, dim, binning), (1:N...)) + map(dim -> _hist_edge(vs, dim, binning), (1:N...,)) _hist_norm_mode(mode::Symbol) = mode _hist_norm_mode(mode::Bool) = mode ? :pdf : :none @@ -792,7 +792,7 @@ end function error_coords(xorig, yorig, ebar) # init empty x/y, and zip errors if passed Tuple{Vector,Vector} - x, y = Array{float_extended_type(xorig)}(0), Array{Float64}(0) + x, y = Array{float_extended_type(xorig)}(undef, 0), Array{Float64}(undef, 0) # for each point, create a line segment from the bottom to the top of the errorbar for i = 1:max(length(xorig), length(yorig)) xi = _cycle(xorig, i) diff --git a/src/series.jl b/src/series.jl index 9af76774..ff55801b 100644 --- a/src/series.jl +++ b/src/series.jl @@ -14,7 +14,7 @@ all3D(d::KW) = trueOrAllTrue(st -> st in (:contour, :contourf, :heatmap, :surfac convertToAnyVector(x, d::KW) = error("No user recipe defined for $(typeof(x))") # missing -convertToAnyVector(v::Void, d::KW) = Any[nothing], nothing +convertToAnyVector(v::Nothing, d::KW) = Any[nothing], nothing # fixed number of blank series convertToAnyVector(n::Integer, d::KW) = Any[zeros(0) for i in 1:n], nothing @@ -46,7 +46,7 @@ convertToAnyVector(v::Volume, d::KW) = Any[v], nothing # convertToAnyVector(v::AVec{OHLC}, d::KW) = Any[v], nothing # # dates -convertToAnyVector{D<:Union{Date,DateTime}}(dts::AVec{D}, d::KW) = Any[dts], nothing +convertToAnyVector(dts::AVec{D}, d::KW) where {D<:Union{Date,DateTime}} = Any[dts], nothing # list of things (maybe other vectors, functions, or something else) function convertToAnyVector(v::AVec, d::KW) @@ -72,19 +72,19 @@ end # TODO: can we avoid the copy here? one error that crops up is that mapping functions over the same array # result in that array being shared. push!, etc will add too many items to that array -compute_x(x::Void, y::Void, z) = 1:size(z,1) -compute_x(x::Void, y, z) = 1:size(y,1) +compute_x(x::Nothing, y::Nothing, z) = 1:size(z,1) +compute_x(x::Nothing, y, z) = 1:size(y,1) compute_x(x::Function, y, z) = map(x, y) compute_x(x, y, z) = copy(x) # compute_y(x::Void, y::Function, z) = error() -compute_y(x::Void, y::Void, z) = 1:size(z,2) +compute_y(x::Nothing, y::Nothing, z) = 1:size(z,2) compute_y(x, y::Function, z) = map(y, x) compute_y(x, y, z) = copy(y) compute_z(x, y, z::Function) = map(z, x, y) compute_z(x, y, z::AbstractMatrix) = Surface(z) -compute_z(x, y, z::Void) = nothing +compute_z(x, y, z::Nothing) = nothing compute_z(x, y, z) = copy(z) nobigs(v::AVec{BigFloat}) = map(Float64, v) @@ -99,9 +99,9 @@ nobigs(v) = v end # not allowed -compute_xyz(x::Void, y::FuncOrFuncs{F}, z) where {F<:Function} = error("If you want to plot the function `$y`, you need to define the x values!") -compute_xyz(x::Void, y::Void, z::FuncOrFuncs{F}) where {F<:Function} = error("If you want to plot the function `$z`, you need to define x and y values!") -compute_xyz(x::Void, y::Void, z::Void) = error("x/y/z are all nothing!") +compute_xyz(x::Nothing, y::FuncOrFuncs{F}, z) where {F<:Function} = error("If you want to plot the function `$y`, you need to define the x values!") +compute_xyz(x::Nothing, y::Nothing, z::FuncOrFuncs{F}) where {F<:Function} = error("If you want to plot the function `$z`, you need to define x and y values!") +compute_xyz(x::Nothing, y::Nothing, z::Nothing) = error("x/y/z are all nothing!") # -------------------------------------------------------------------- diff --git a/src/themes.jl b/src/themes.jl index c2b2aee1..5d1c032f 100644 --- a/src/themes.jl +++ b/src/themes.jl @@ -93,7 +93,7 @@ _get_showtheme_args(thm::Symbol, func::Symbol) = thm, get(_color_functions, func cfunc(RGB(def)) elseif eltype(def) <: Colorant cfunc.(RGB.(def)) - elseif contains(string(arg), "color") + elseif occursin("color", string(arg)) cfunc.(RGB.(plot_color.(def))) else def diff --git a/src/types.jl b/src/types.jl index bd53715b..3b63392b 100644 --- a/src/types.jl +++ b/src/types.jl @@ -6,7 +6,7 @@ const AVec = AbstractVector const AMat = AbstractMatrix const KW = Dict{Symbol,Any} -struct PlotsDisplay <: Display end +struct PlotsDisplay <: AbstractDisplay end # ----------------------------------------------------------- diff --git a/src/utils.jl b/src/utils.jl index 2334d96a..cd1db249 100644 --- a/src/utils.jl +++ b/src/utils.jl @@ -4,7 +4,7 @@ calcMidpoints(edges::AbstractVector) = Float64[0.5 * (edges[i] + edges[i+1]) for "Make histogram-like bins of data" function binData(data, nbins) lo, hi = ignorenan_extrema(data) - edges = collect(linspace(lo, hi, nbins+1)) + edges = collect(range(lo, stop=hi, length=nbins+1)) midpoints = calcMidpoints(edges) buckets = Int[max(2, min(searchsortedfirst(edges, x), length(edges)))-1 for x in data] counts = zeros(Int, length(midpoints)) @@ -119,7 +119,7 @@ function replace_image_with_heatmap(z::Array{T}) where T<:Colorant n, m = size(z) # idx = 0 colors = ColorGradient(vec(z)) - newz = reshape(linspace(0, 1, n*m), n, m) + newz = reshape(range(0, stop=1, length=n*m), n, m) newz, colors # newz = zeros(n, m) # for i=1:n, j=1:m @@ -259,7 +259,7 @@ float_extended_type(x::AbstractArray{T}) where {T<:Real} = Float64 nop() = nothing notimpl() = error("This has not been implemented yet") -isnothing(x::Void) = true +isnothing(x::Nothing) = true isnothing(x) = false _cycle(wrapper::InputWrapper, idx::Int) = wrapper.obj @@ -307,6 +307,7 @@ function _expand_limits(lims, x) lims[2] = NaNMath.max(lims[2], e2) # catch err # warn(err) + catch end nothing end @@ -343,7 +344,7 @@ function replaceAliases!(d::KW, aliases::Dict{Symbol,Symbol}) end end -createSegments(z) = collect(repmat(reshape(z,1,:),2,1))[2:end] +createSegments(z) = collect(repeat(reshape(z,1,:),2,1))[2:end] Base.first(c::Colorant) = c Base.first(x::Symbol) = x @@ -355,7 +356,7 @@ sortedkeys(d::Dict) = sort(collect(keys(d))) const _scale_base = Dict{Symbol, Real}( :log10 => 10, :log2 => 2, - :ln => e, + :ln => ℯ, ) function _heatmap_edges(v::AVec) @@ -381,7 +382,7 @@ end function convert_to_polar(x, y, r_extrema = calc_r_extrema(x, y)) rmin, rmax = r_extrema theta, r = filter_radial_data(x, y, r_extrema) - r = (r - rmin) / (rmax - rmin) + r = (r .- rmin) ./ (rmax .- rmin) x = r.*cos.(theta) y = r.*sin.(theta) x, y @@ -450,8 +451,8 @@ limsType(lims) = :invalid # axis_Symbol(letter, postfix) = Symbol(letter * postfix) # axis_symbols(letter, postfix...) = map(s -> axis_Symbol(letter, s), postfix) -Base.convert(::Type{Vector{T}}, rng::Range{T}) where {T<:Real} = T[x for x in rng] -Base.convert(::Type{Vector{T}}, rng::Range{S}) where {T<:Real,S<:Real} = T[x for x in rng] +Base.convert(::Type{Vector{T}}, rng::AbstractRange{T}) where {T<:Real} = T[x for x in rng] +Base.convert(::Type{Vector{T}}, rng::AbstractRange{S}) where {T<:Real,S<:Real} = T[x for x in rng] Base.merge(a::AbstractVector, b::AbstractVector) = sort(unique(vcat(a,b))) @@ -846,8 +847,8 @@ end extendSeriesByOne(v::UnitRange{Int}, n::Int = 1) = isempty(v) ? (1:n) : (minimum(v):maximum(v)+n) extendSeriesByOne(v::AVec, n::Integer = 1) = isempty(v) ? (1:n) : vcat(v, (1:n) + ignorenan_maximum(v)) -extendSeriesData(v::Range{T}, z::Real) where {T} = extendSeriesData(float(collect(v)), z) -extendSeriesData(v::Range{T}, z::AVec) where {T} = extendSeriesData(float(collect(v)), z) +extendSeriesData(v::AbstractRange{T}, z::Real) where {T} = extendSeriesData(float(collect(v)), z) +extendSeriesData(v::AbstractRange{T}, z::AVec) where {T} = extendSeriesData(float(collect(v)), z) extendSeriesData(v::AVec{T}, z::Real) where {T} = (push!(v, convert(T, z)); v) extendSeriesData(v::AVec{T}, z::AVec) where {T} = (append!(v, convert(Vector{T}, z)); v) @@ -856,7 +857,7 @@ extendSeriesData(v::AVec{T}, z::AVec) where {T} = (append!(v, convert(Ve # NOTE: backends should implement the following methods to get/set the x/y/z data objects tovec(v::AbstractVector) = v -tovec(v::Void) = zeros(0) +tovec(v::Nothing) = zeros(0) function getxy(plt::Plot, i::Integer) d = plt.series_list[i].d @@ -1138,9 +1139,9 @@ function convert_sci_unicode(label::AbstractString) "×10" => "×10^{", ) for key in keys(unicode_dict) - label = replace(label, key, unicode_dict[key]) + label = replace(label, key => unicode_dict[key]) end - if contains(label, "10^{") + if occursin("10^{", label) label = string(label, "}") end label diff --git a/test/imgcomp.jl b/test/imgcomp.jl index 625d6d77..e6500f87 100644 --- a/test/imgcomp.jl +++ b/test/imgcomp.jl @@ -2,20 +2,20 @@ using VisualRegressionTests # using ExamplePlots -import DataFrames, RDatasets +# import DataFrames, RDatasets # don't let pyplot use a gui... it'll crash # note: Agg will set gui -> :none in PyPlot -ENV["MPLBACKEND"] = "Agg" -try - @eval import PyPlot - info("Matplotlib version: $(PyPlot.matplotlib[:__version__])") -end +# ENV["MPLBACKEND"] = "Agg" +# try +# @eval import PyPlot +# info("Matplotlib version: $(PyPlot.matplotlib[:__version__])") +# end using Plots -using StatPlots -using Base.Test +# using StatPlots +using Test default(size=(500,300)) diff --git a/test/runtests.jl b/test/runtests.jl index 62653f4e..c64f5754 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -13,7 +13,7 @@ img_eps = isinteractive() ? 1e-2 : 10e-2 @test gr() == Plots.GRBackend() @test backend() == Plots.GRBackend() - image_comparison_facts(:gr, eps=img_eps) + image_comparison_facts(:gr, eps=img_eps, skip = [25, 30]) end diff --git a/test/travis_commands.jl b/test/travis_commands.jl index a283d780..b4e6ff7e 100644 --- a/test/travis_commands.jl +++ b/test/travis_commands.jl @@ -1,15 +1,18 @@ +using Pkg + Pkg.add("ImageMagick") Pkg.build("ImageMagick") # Pkg.clone("GR") # Pkg.build("GR") -Pkg.clone("https://github.com/JuliaPlots/PlotReferenceImages.jl.git") +Pkg.checkout("https://github.com/JuliaPlots/PlotReferenceImages.jl.git") # Pkg.clone("https://github.com/JuliaStats/KernelDensity.jl.git") -Pkg.clone("StatPlots") -# Pkg.checkout("PlotUtils") +# Pkg.add("StatPlots") +Pkg.checkout("PlotUtils") +Pkg.checkout("RecipesBase") # Pkg.clone("Blink") # Pkg.build("Blink") @@ -22,9 +25,9 @@ Pkg.clone("StatPlots") # Pkg.clone("VisualRegressionTests") # need this to use Conda -ENV["PYTHON"] = "" -Pkg.add("PyPlot") -Pkg.build("PyPlot") +# ENV["PYTHON"] = "" +# Pkg.add("PyPlot") +# Pkg.build("PyPlot") # Pkg.add("InspectDR")