From 9d84e53bcb5cf23986d143037c4621cafb3c1d5d Mon Sep 17 00:00:00 2001
From: t-bltg <tf.bltg@gmail.com>
Date: Fri, 17 Sep 2021 12:00:40 +0200
Subject: [PATCH] Test cleanup (#3821)

---
 test/runtests.jl | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/test/runtests.jl b/test/runtests.jl
index d847b5fc..584e0d11 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -132,28 +132,30 @@ const PLOTS_IMG_TOL = parse(Float64, get(ENV, "PLOTS_IMG_TOL", is_ci() ? "1e-4"
         @test unicodeplots() == Plots.UnicodePlotsBackend()
         @test backend() == Plots.UnicodePlotsBackend()
 
+        io = IOBuffer()
+
         # lets just make sure it runs without error
         p = plot(rand(10))
-        @test isa(p, Plots.Plot) == true
-        @test isa(display(p), Nothing) == true
+        @test p isa Plots.Plot
+        @test show(io, p) isa Nothing
         p = bar(randn(10))
-        @test isa(p, Plots.Plot) == true
-        @test isa(display(p), Nothing) == true
+        @test p isa Plots.Plot
+        @test show(io, p) isa Nothing
         p = plot([1, 2], [3, 4])
         annotate!(p, [(1.5, 3.2, Plots.text("Test", :red, :center))])
         hline!(p, [3.1])
-        @test isa(p, Plots.Plot) == true
-        @test isa(display(p), Nothing) == true
+        @test p isa Plots.Plot
+        @test show(io, p) isa Nothing
         p = plot([Dates.Date(2019, 1, 1), Dates.Date(2019, 2, 1)], [3, 4])
         hline!(p, [3.1])
         annotate!(p, [(Dates.Date(2019, 1, 15), 3.2, Plots.text("Test", :red, :center))])
-        @test isa(p, Plots.Plot) == true
-        @test isa(display(p), Nothing) == true
+        @test p isa Plots.Plot
+        @test show(io, p) isa Nothing
         p = plot([Dates.Date(2019, 1, 1), Dates.Date(2019, 2, 1)], [3, 4])
         annotate!(p, [(Dates.Date(2019, 1, 15), 3.2, :auto)])
         hline!(p, [3.1])
-        @test isa(p, Plots.Plot) == true
-        @test isa(display(p), Nothing) == true
+        @test p isa Plots.Plot
+        @test show(io, p) isa Nothing
     end
 
     @testset "PlotlyJS" begin
@@ -161,8 +163,8 @@ const PLOTS_IMG_TOL = parse(Float64, get(ENV, "PLOTS_IMG_TOL", is_ci() ? "1e-4"
         @test backend() == Plots.PlotlyJSBackend()
 
         p = plot(rand(10))
-        @test isa(p, Plots.Plot) == true
-        @test_broken isa(display(p), Nothing) == true
+        @test p isa Plots.Plot
+        @test_broken display(p) isa Nothing
     end
 end