From 9bf4bda852fc62bfb9bc3bc0b027e30c167b2b8d Mon Sep 17 00:00:00 2001 From: Daniel Schwabeneder Date: Thu, 9 Apr 2020 18:13:28 +0200 Subject: [PATCH] fix zerolines framestyle and don't draw tick marks for zerolines and grid framestyle --- src/backends/pgfplotsx.jl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/backends/pgfplotsx.jl b/src/backends/pgfplotsx.jl index 7874b2fc..3d54cf65 100644 --- a/src/backends/pgfplotsx.jl +++ b/src/backends/pgfplotsx.jl @@ -1013,6 +1013,8 @@ function pgfx_axis!(opt::PGFPlotsX.Options, sp::Subplot, letter) # ticks on or off if axis[:ticks] in (nothing, false, :none) || framestyle == :none push!(opt, "$(letter)majorticks" => "false") + elseif framestyle in (:grid, :zerolines) + push!(opt, "$letter tick style" => PGFPlotsX.Options("draw" => "none")) end # grid on or off @@ -1098,7 +1100,9 @@ function pgfx_axis!(opt::PGFPlotsX.Options, sp::Subplot, letter) # minor ticks # NOTE: PGFPlots would provide "minor x ticks num", but this only places minor ticks # between major ticks and not outside first and last tick to the axis limits. - # Hence, we hack around with extra ticks. + # Hence, we hack around with extra ticks. Unfortunately this conflicts with + # `:zerolines` framestyle hack. So minor ticks are not working with + # `:zerolines`. minor_ticks = get_minor_ticks(sp, axis, ticks) if minor_ticks !== nothing minor_ticks = @@ -1144,7 +1148,7 @@ function pgfx_axis!(opt::PGFPlotsX.Options, sp::Subplot, letter) opt, string("extra ", letter, " tick style") => PGFPlotsX.Options( "grid" => "major", - "major grid style" => pgfx_linestyle( + string(letter, " grid style") => pgfx_linestyle( pgfx_thickness_scaling(sp), axis[:foreground_color_border], 1.0,