From cd958a6c6885706b4d49236813a3b8af36bf4ce9 Mon Sep 17 00:00:00 2001 From: "Michael K. Borregaard" Date: Mon, 2 Oct 2017 08:53:41 +0200 Subject: [PATCH 1/2] Fix barwidth to minimum(diff) not mean(diff) --- src/axes.jl | 2 +- src/recipes.jl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/axes.jl b/src/axes.jl index f989a8fb..303e24db 100644 --- a/src/axes.jl +++ b/src/axes.jl @@ -365,7 +365,7 @@ function expand_extrema!(sp::Subplot, d::KW) bw = d[:bar_width] if bw == nothing - bw = d[:bar_width] = _bar_width * ignorenan_mean(diff(data)) + bw = d[:bar_width] = _bar_width * ignorenan_minimum(filter(x->x>0,diff(data))) end axis = sp.attr[Symbol(dsym, :axis)] expand_extrema!(axis, ignorenan_maximum(data) + 0.5maximum(bw)) diff --git a/src/recipes.jl b/src/recipes.jl index 876b3897..5f844967 100644 --- a/src/recipes.jl +++ b/src/recipes.jl @@ -289,7 +289,7 @@ end # compute half-width of bars bw = d[:bar_width] hw = if bw == nothing - 0.5*_bar_width*ignorenan_mean(diff(procx)) + 0.5*_bar_width*ignorenan_minimum(filter(x->x>0, diff(procx))) else Float64[0.5_cycle(bw,i) for i=1:length(procx)] end From f3566a493362c88239b3ece5b2db601a947066d5 Mon Sep 17 00:00:00 2001 From: "Michael K. Borregaard" Date: Mon, 2 Oct 2017 10:02:39 +0200 Subject: [PATCH 2/2] sort before taking diff --- src/axes.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/axes.jl b/src/axes.jl index 303e24db..debb3773 100644 --- a/src/axes.jl +++ b/src/axes.jl @@ -365,7 +365,7 @@ function expand_extrema!(sp::Subplot, d::KW) bw = d[:bar_width] if bw == nothing - bw = d[:bar_width] = _bar_width * ignorenan_minimum(filter(x->x>0,diff(data))) + bw = d[:bar_width] = _bar_width * ignorenan_minimum(filter(x->x>0,diff(sort(data)))) end axis = sp.attr[Symbol(dsym, :axis)] expand_extrema!(axis, ignorenan_maximum(data) + 0.5maximum(bw))