From 79cf62cf91ed4e1a1fd4f5112c93dbd383e04a65 Mon Sep 17 00:00:00 2001
From: Jks Liu <chinatianma@gmail.com>
Date: Wed, 1 Dec 2021 20:45:23 +0800
Subject: [PATCH] Upgrade plotly.js to v2.6.3 (#3958)

* Upgrade plotly.js to version 2.6.3

* plotly polar support, api changed in plotly.js v2.x.x

https://plotly.com/javascript/polar-chart/
https://community.plotly.com/t/announcing-plotly-js-2-0/53675
---
 src/Plots.jl           |  2 +-
 src/backends/plotly.jl | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/Plots.jl b/src/Plots.jl
index 4aff05a2..8add081e 100644
--- a/src/Plots.jl
+++ b/src/Plots.jl
@@ -203,7 +203,7 @@ import RecipesPipeline:
 
 # Use fixed version of Plotly instead of the latest one for stable dependency
 # Ref: https://github.com/JuliaPlots/Plots.jl/pull/2779
-const _plotly_min_js_filename = "plotly-1.57.1.min.js"
+const _plotly_min_js_filename = "plotly-2.6.3.min.js"
 
 include("types.jl")
 include("utils.jl")
diff --git a/src/backends/plotly.jl b/src/backends/plotly.jl
index adf8adb7..05e87f11 100644
--- a/src/backends/plotly.jl
+++ b/src/backends/plotly.jl
@@ -1013,8 +1013,9 @@ function plotly_polar!(plotattributes_out::KW, series::Series)
     # convert polar plots x/y to theta/radius
     if ispolar(series[:subplot])
         theta, r = pop!(plotattributes_out, :x), pop!(plotattributes_out, :y)
-        plotattributes_out[:t] = rad2deg.(theta)
+        plotattributes_out[:theta] = rad2deg.(theta)
         plotattributes_out[:r] = r
+        plotattributes_out[:type] = :scatterpolar
     end
 end
 
@@ -1078,10 +1079,10 @@ function plotly_html_body(plt, style = nothing)
         requirejs_prefix = """
             requirejs.config({
                 paths: {
-                    Plotly: '$(plotly_no_ext)'
+                    Plotly2: '$(plotly_no_ext)'
                 }
             });
-            require(['Plotly'], function (Plotly) {
+            require(['Plotly2'], function (Plotly2) {
         """
         requirejs_suffix = "});"
     end
@@ -1100,8 +1101,7 @@ end
 
 function js_body(plt::Plot, uuid)
     js = """
-        var PLOT = document.getElementById('$(uuid)');
-        Plotly.plot(PLOT, $(plotly_series_json(plt)), $(plotly_layout_json(plt)));
+        Plotly2.newPlot('$(uuid)', $(plotly_series_json(plt)), $(plotly_layout_json(plt)));
     """
 end