From 74ec895aca2a87039e756922c48ab1181debea3f Mon Sep 17 00:00:00 2001 From: Simon Christ Date: Sat, 7 Dec 2019 15:18:47 +0100 Subject: [PATCH] fix unintended filling of simple lines --- src/backends/pgfplotsx.jl | 3 +-- test/test_pgfplotsx.jl | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/backends/pgfplotsx.jl b/src/backends/pgfplotsx.jl index 92e515e3..6578ff0f 100644 --- a/src/backends/pgfplotsx.jl +++ b/src/backends/pgfplotsx.jl @@ -235,8 +235,7 @@ function (pgfx_plot::PGFPlotsXPlot)(plt::Plot{PGFPlotsXBackend}) segment_opt = merge( segment_opt, pgfx_marker(opt, i) ) end if st == :shape || - isfilledcontour(series) || - series[:ribbon] === nothing + isfilledcontour(series) segment_opt = merge( segment_opt, pgfx_fillstyle(opt, i) ) end # add fillrange diff --git a/test/test_pgfplotsx.jl b/test/test_pgfplotsx.jl index 90167f90..a9cebf44 100644 --- a/test/test_pgfplotsx.jl +++ b/test/test_pgfplotsx.jl @@ -16,6 +16,9 @@ end Plots._update_plot_object(pgfx_plot) @test pgfx_plot.o.the_plot isa PGFPlotsX.TikzDocument @test pgfx_plot.series_list[1].plotattributes[:quiver] === nothing + axis = Plots.pgfx_axes(pgfx_plot.o)[1] + @test count( x-> x isa PGFPlotsX.Plot, axis.contents ) == 1 + @test !haskey(axis.contents[1].options.dict, "fill") @testset "3D docs example" begin n = 100