From 392ced81c920d3edf3b9c439af920be265606f67 Mon Sep 17 00:00:00 2001 From: "Michael K. Borregaard" Date: Tue, 30 May 2017 16:55:30 +0200 Subject: [PATCH] some forgotten extrema -> _extrema --- src/backends/glvisualize.jl | 2 +- src/layouts.jl | 2 +- src/recipes.jl | 2 +- test/runtests.jl | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backends/glvisualize.jl b/src/backends/glvisualize.jl index cf2c9f1c..cc75917f 100644 --- a/src/backends/glvisualize.jl +++ b/src/backends/glvisualize.jl @@ -525,7 +525,7 @@ function hover(to_hover, to_display, window) end function extract_extrema(d, kw_args) - xmin, xmax = extrema(d[:x]); ymin, ymax = _extrema(d[:y]) + xmin, xmax = _extrema(d[:x]); ymin, ymax = _extrema(d[:y]) kw_args[:primitive] = GeometryTypes.SimpleRectangle{Float32}(xmin, ymin, xmax-xmin, ymax-ymin) nothing end diff --git a/src/layouts.jl b/src/layouts.jl index 2e9fd853..9b123839 100644 --- a/src/layouts.jl +++ b/src/layouts.jl @@ -704,7 +704,7 @@ function link_axes!(axes::Axis...) a1 = axes[1] for i=2:length(axes) a2 = axes[i] - expand_extrema!(a1, extrema(a2)) + expand_extrema!(a1, _extrema(a2)) for k in (:extrema, :discrete_values, :continuous_values, :discrete_map) a2[k] = a1[k] end diff --git a/src/recipes.jl b/src/recipes.jl index 4be5018f..e575b645 100644 --- a/src/recipes.jl +++ b/src/recipes.jl @@ -366,7 +366,7 @@ end end # widen limits out a bit - expand_extrema!(axis, widen(extrema(xseg.pts)...)) + expand_extrema!(axis, widen(_extrema(xseg.pts)...)) # switch back if !isvertical(d) diff --git a/test/runtests.jl b/test/runtests.jl index 8434a45f..6e4d3f98 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -83,7 +83,7 @@ facts("Axes") do Plots.discrete_value!(axis, ["x$i" for i=1:5]) Plots.discrete_value!(axis, ["x$i" for i=0:2]) - @fact Plots.extrema(axis) --> (0.5, 7.5) + @fact Plots._extrema(axis) --> (0.5, 7.5) end