mantao/Plots.jl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

error bars behind in scatterplots (#2677)

Browse Source 
* errors behind for :scatter

* fix plots with no seriestype
This commit is contained in:
Simon Christ 2020-05-09 13:05:15 +02:00 committed by GitHub
parent 4e2ee35125
commit 32c725e770
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/pipeline.jl
View File

@ -155,8 +155,23 @@ RecipesPipeline.type_alias(plt::Plot) = get(_typeAliases, st, st)
function RecipesPipeline.plot_setup!(plt::Plot, plotattributes, kw_list) function RecipesPipeline.plot_setup!(plt::Plot, plotattributes, kw_list)
_plot_setup(plt, plotattributes, kw_list) _plot_setup(plt, plotattributes, kw_list)
_subplot_setup(plt, plotattributes, kw_list) _subplot_setup(plt, plotattributes, kw_list)
return nothing
end end
function RecipesPipeline.process_sliced_series_attributes!(plt::Plots.Plot, kw_list)
# swap errors
err_inds = findall(kw -> get(kw, :seriestype, nothing) in (:xerror, :yerror, :zerror), kw_list)
for ind in err_inds
if kw_list[ind-1][:seriestype] == :scatter
tmp = copy(kw_list[ind])
kw_list[ind] = copy(kw_list[ind-1])
kw_list[ind-1] = tmp
end
end
return nothing
end
# TODO: Should some of this logic be moved to RecipesPipeline? # TODO: Should some of this logic be moved to RecipesPipeline?
function _plot_setup(plt::Plot, plotattributes::AKW, kw_list::Vector{KW}) function _plot_setup(plt::Plot, plotattributes::AKW, kw_list::Vector{KW})
# merge in anything meant for the Plot # merge in anything meant for the Plot
@ -274,6 +289,7 @@ function RecipesPipeline.slice_series_attributes!(plt::Plot, kw_list, kw)
# in series attributes given as vector with one element per series, # in series attributes given as vector with one element per series,
# select the value for current series # select the value for current series
_slice_series_args!(kw, plt, sp, series_idx(kw_list, kw)) _slice_series_args!(kw, plt, sp, series_idx(kw_list, kw))
return nothing
end end
RecipesPipeline.series_defaults(plt::Plot) = _series_defaults # in args.jl RecipesPipeline.series_defaults(plt::Plot) = _series_defaults # in args.jl