From df023d6bdb42138029e4208db6c840957d775a2e Mon Sep 17 00:00:00 2001 From: Romain Franconville Date: Fri, 17 Nov 2017 15:02:16 -0500 Subject: [PATCH 1/3] Always define axis range explicitely --- src/backends/plotly.jl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/backends/plotly.jl b/src/backends/plotly.jl index 3b149a20..19c3ab14 100644 --- a/src/backends/plotly.jl +++ b/src/backends/plotly.jl @@ -252,7 +252,7 @@ function plotly_axis(axis::Axis, sp::Subplot) end ax[:tickangle] = -axis[:rotation] - + ax[:range] = axis_limits(axis) if !(axis[:ticks] in (nothing, :none)) ax[:titlefont] = plotly_font(axis[:guidefont], axis[:foreground_color_guide]) ax[:type] = plotly_scale(axis[:scale]) @@ -288,6 +288,7 @@ function plotly_axis(axis::Axis, sp::Subplot) ax[:showgrid] = false end + ax end From c01d8199f9acd24f663769213b81d893c9e624b4 Mon Sep 17 00:00:00 2001 From: Romain Franconville Date: Fri, 17 Nov 2017 15:29:55 -0500 Subject: [PATCH 2/3] Also include scaling --- src/backends/plotly.jl | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/backends/plotly.jl b/src/backends/plotly.jl index 19c3ab14..b7670449 100644 --- a/src/backends/plotly.jl +++ b/src/backends/plotly.jl @@ -252,7 +252,9 @@ function plotly_axis(axis::Axis, sp::Subplot) end ax[:tickangle] = -axis[:rotation] - ax[:range] = axis_limits(axis) + lims = axis_limits(axis) + ax[:range] = map(scalefunc(axis[:scale]), lims) + if !(axis[:ticks] in (nothing, :none)) ax[:titlefont] = plotly_font(axis[:guidefont], axis[:foreground_color_guide]) ax[:type] = plotly_scale(axis[:scale]) @@ -261,10 +263,10 @@ function plotly_axis(axis::Axis, sp::Subplot) ax[:linecolor] = rgba_string(axis[:foreground_color_axis]) # lims - lims = axis[:lims] - if lims != :auto && limsType(lims) == :limits - ax[:range] = map(scalefunc(axis[:scale]), lims) - end + + #if lims != :auto && limsType(lims) == :limits + #ax[:range] = map(scalefunc(axis[:scale]), lims) + #end # flip if axis[:flip] From 5a0744e2f137b2eec85e6616ad1fe454a5d733e6 Mon Sep 17 00:00:00 2001 From: Romain Franconville Date: Fri, 17 Nov 2017 16:06:14 -0500 Subject: [PATCH 3/3] Remove commented code --- src/backends/plotly.jl | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/backends/plotly.jl b/src/backends/plotly.jl index b7670449..b0906444 100644 --- a/src/backends/plotly.jl +++ b/src/backends/plotly.jl @@ -262,12 +262,6 @@ function plotly_axis(axis::Axis, sp::Subplot) ax[:tickcolor] = framestyle in (:zerolines, :grid) || !axis[:showaxis] ? rgba_string(invisible()) : rgb_string(axis[:foreground_color_axis]) ax[:linecolor] = rgba_string(axis[:foreground_color_axis]) - # lims - - #if lims != :auto && limsType(lims) == :limits - #ax[:range] = map(scalefunc(axis[:scale]), lims) - #end - # flip if axis[:flip] ax[:autorange] = "reversed"