From 4ac81d12df1d5e6572c3e24a07ac587ff3842ed3 Mon Sep 17 00:00:00 2001 From: Jeremy Bejanin Date: Sun, 7 Feb 2021 12:00:00 -0500 Subject: [PATCH] don't stringify argument to `warn_on_recipe_aliases!` early needs matching RecipesPipeline changes --- src/pipeline.jl | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/pipeline.jl b/src/pipeline.jl index 8f493cb2..c9ed7e25 100644 --- a/src/pipeline.jl +++ b/src/pipeline.jl @@ -5,13 +5,24 @@ function RecipesPipeline.warn_on_recipe_aliases!( plt::Plot, plotattributes::AKW, - recipe_type, - signature_string + recipe_type::Symbol, + args ) for k in keys(plotattributes) if !is_default_attribute(k) dk = get(_keyAliases, k, k) if k !== dk + if recipe_type == :user + signature_string = RecipesPipeline.userrecipe_signature_string(args) + elseif recipe_type == :type + signature_string = RecipesPipeline.typerecipe_signature_string(args) + elseif recipe_type == :plot + signature_string = RecipesPipeline.plotrecipe_signature_string(args) + elseif recipe_type == :series + signature_string = RecipesPipeline.seriesrecipe_signature_string(args) + else + throw(ArgumentError("Invalid recipe type `$recipe_type`")) + end @warn "Attribute alias `$k` detected in the $recipe_type recipe defined for the signature $signature_string. To ensure expected behavior it is recommended to use the default attribute `$dk`." end plotattributes[dk] = RecipesPipeline.pop_kw!(plotattributes, k)