From f43f2956f5cdf0d064bc3fb2b1376afbd054febe Mon Sep 17 00:00:00 2001 From: Daniel Schwabeneder Date: Fri, 15 Sep 2017 18:39:56 +0200 Subject: [PATCH 1/2] activate clims for inactive colorbar --- src/backends/pyplot.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backends/pyplot.jl b/src/backends/pyplot.jl index 3bdb52a4..e86d71e4 100644 --- a/src/backends/pyplot.jl +++ b/src/backends/pyplot.jl @@ -445,7 +445,7 @@ function py_add_series(plt::Plot{PyPlotBackend}, series::Series) # handle zcolor and get c/cmap needs_colorbar = hascolorbar(sp) - extrakw = if needs_colorbar + extrakw = if needs_colorbar || is_2tuple(sp[:clims]) vmin, vmax = get_clims(sp) KW(:vmin => vmin, :vmax => vmax) else From 9eae2ad76b48fb0d1d99b0c25f85f1cc5a58d039 Mon Sep 17 00:00:00 2001 From: Daniel Schwabeneder Date: Fri, 15 Sep 2017 18:42:38 +0200 Subject: [PATCH 2/2] remove unnecessary setting of needs_colorbar --- src/backends/pyplot.jl | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/backends/pyplot.jl b/src/backends/pyplot.jl index e86d71e4..8d0d310e 100644 --- a/src/backends/pyplot.jl +++ b/src/backends/pyplot.jl @@ -530,7 +530,6 @@ function py_add_series(plt::Plot{PyPlotBackend}, series::Series) lc end push!(handles, handle) - needs_colorbar = true end a = series[:arrow] @@ -628,12 +627,10 @@ function py_add_series(plt::Plot{PyPlotBackend}, series::Series) extrakw... ) push!(handles, handle) - needs_colorbar = true end if st in (:contour, :contour3d) z = transpose_z(series, z.surf) - needs_colorbar = true if st == :contour3d extrakw[:extend3d] = true @@ -678,7 +675,6 @@ function py_add_series(plt::Plot{PyPlotBackend}, series::Series) else extrakw[:cmap] = py_fillcolormap(series) end - needs_colorbar = true end handle = ax[st == :surface ? :plot_surface : :plot_wireframe](x, y, z; label = series[:label], @@ -701,7 +697,6 @@ function py_add_series(plt::Plot{PyPlotBackend}, series::Series) offset = (zdir == "y" ? ignorenan_maximum : ignorenan_minimum)(mat) # where to draw the contour plane ) push!(handles, handle) - needs_colorbar = true end end @@ -722,7 +717,6 @@ function py_add_series(plt::Plot{PyPlotBackend}, series::Series) extrakw... ) push!(handles, handle) - needs_colorbar = true else error("Unsupported z type $(typeof(z)) for seriestype=$st") end @@ -770,7 +764,6 @@ function py_add_series(plt::Plot{PyPlotBackend}, series::Series) extrakw... ) push!(handles, handle) - needs_colorbar = true end if st == :shape