From 04d8beb7b3aef1771755df201736c834ab29b235 Mon Sep 17 00:00:00 2001 From: t-bltg Date: Mon, 30 Aug 2021 23:46:04 +0200 Subject: [PATCH] Revert "Apply suggestions from code review" This reverts commit abccc9f5bacbe7664e87f14101fecc47e39ba9b1. --- src/utils.jl | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/utils.jl b/src/utils.jl index 6f6dd351..159805fc 100644 --- a/src/utils.jl +++ b/src/utils.jl @@ -1215,14 +1215,22 @@ function mesh3d_triangles(x, y, z, cns) return X, Y, Z end -const _attrsymbolcache = Dict{Symbol, Dict{Symbol, Symbol}}( - :x => Dict( k => Symbol("x", String(k)) for k in keys(_axis_defaults)), - :y => Dict( k => Symbol("y", String(k)) for k in keys(_axis_defaults)), - :z => Dict( k => Symbol("z", String(k)) for k in keys(_axis_defaults)) -) +const _attrsymbolcache = Dict{Symbol, Dict{Symbol, Symbol}}() get_attr_symbol(letter::Symbol, keyword::String) = get_attr_symbol(letter, Symbol(keyword)) function get_attr_symbol(letter::Symbol, keyword::Symbol) - return _attrsymbolcache[letter][keyword] + lt = if haskey(_attrsymbolcache, letter) + _attrsymbolcache[letter] + else + _attrsymbolcache[letter] = Dict{Symbol, Symbol}() + end + + lk = if haskey(lt, keyword) + lt[keyword] + else + lt[keyword] = Symbol(letter, keyword) + end + + return lk end