From db8dcfc433327405ee1e4e9e9c37cbd935d3c90b Mon Sep 17 00:00:00 2001 From: Michal Sojka Date: Mon, 6 Sep 2021 15:57:50 +0200 Subject: [PATCH] Fix bounds error in hist recipe When running hist([1,2,3], bs=2), the following error is produced: ERROR: BoundsError: attempt to access 1-element Vector{Float64} at index [2] Stacktrace: [1] getindex @ ./array.jl:801 [inlined] [2] hist(v::Vector{Int64}; range::Vector{Float64}, bs::Int64, nbins::Int64, pad::Bool) @ Gnuplot ~/.julia/dev/Gnuplot/src/Gnuplot.jl:1873 [3] top-level scope @ REPL[25]:1 --- src/Gnuplot.jl | 2 +- test/runtests.jl | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Gnuplot.jl b/src/Gnuplot.jl index 18a8057..7c82e50 100644 --- a/src/Gnuplot.jl +++ b/src/Gnuplot.jl @@ -1853,9 +1853,9 @@ function hist(v::Vector{T}; range=[NaN,NaN], bs=NaN, nbins=0, pad=true) where T end @assert sum(hh.weights) == length(i) x = collect(hh.edges[1]) + binsize = x[2] - x[1] x = (x[1:end-1] .+ x[2:end]) ./ 2 h = hh.weights - binsize = x[2] - x[1] if pad x = [x[1]-binsize, x..., x[end]+binsize] h = [0, h..., 0] diff --git a/test/runtests.jl b/test/runtests.jl index 76a91ed..53fe0fe 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -286,4 +286,7 @@ Gnuplot.quit(:default) Gnuplot.options.dry = true @gp hist(randn(1000)) +# Various hist() corner cases +@gp hist([1,2,3], bs=2) + Gnuplot.quitall()